Send users mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of users digest..."
Today's Topics:
1. Re: [RFC 01/32] rt2800: make rt2800_init_bbp return void
(Helmut Schaa)
2. Re: [RFC 01/32] rt2800: make rt2800_init_bbp return void
(Helmut Schaa)
3. Re: [RFC 00/32] BBP initialization split (Helmut Schaa)
----------------------------------------------------------------------
Message: 1
Date: Thu, 16 May 2013 16:41:45 +0200
From: Helmut Schaa <[email protected]>
To: "[email protected]" <[email protected]>
Cc: rt2x00 Users List <[email protected]>
Subject: Re: [rt2x00-users] [RFC 01/32] rt2800: make rt2800_init_bbp
return void
Message-ID:
<CAGXE3d9dpM=-c0xssy577qrcvtthq5vizzqpvu0e-ss7thl...@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
On Wed, May 8, 2013 at 9:49 PM, <[email protected]> wrote:
> From: Stanislaw Gruszka <[email protected]>
>
> This function can not fail, we always return 0.
Fine with me.
Any special reason why you replace -EACCES; with -EIO?
Helmut
> Signed-off-by: Stanislaw Gruszka <[email protected]>
> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 14 +++++---------
> 1 files changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c
> b/drivers/net/wireless/rt2x00/rt2800lib.c
> index b52d70c..f431dcb 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -4027,20 +4027,16 @@ static void rt2800_init_bbp_5592(struct rt2x00_dev
> *rt2x00dev)
> rt2800_bbp_write(rt2x00dev, 103, 0xc0);
> }
>
> -static int rt2800_init_bbp(struct rt2x00_dev *rt2x00dev)
> +static void rt2800_init_bbp(struct rt2x00_dev *rt2x00dev)
> {
> unsigned int i;
> u16 eeprom;
> u8 reg_id;
> u8 value;
>
> - if (unlikely(rt2800_wait_bbp_rf_ready(rt2x00dev) ||
> - rt2800_wait_bbp_ready(rt2x00dev)))
> - return -EACCES;
> -
> if (rt2x00_rt(rt2x00dev, RT5592)) {
> rt2800_init_bbp_5592(rt2x00dev);
> - return 0;
> + return;
> }
>
> if (rt2x00_rt(rt2x00dev, RT3352)) {
> @@ -4337,8 +4333,6 @@ static int rt2800_init_bbp(struct rt2x00_dev *rt2x00dev)
> rt2800_bbp_write(rt2x00dev, reg_id, value);
> }
> }
> -
> - return 0;
> }
>
> static void rt2800_led_open_drain_enable(struct rt2x00_dev *rt2x00dev)
> @@ -5189,9 +5183,11 @@ int rt2800_enable_radio(struct rt2x00_dev *rt2x00dev)
> }
> msleep(1);
>
> - if (unlikely(rt2800_init_bbp(rt2x00dev)))
> + if (unlikely(rt2800_wait_bbp_rf_ready(rt2x00dev) ||
> + rt2800_wait_bbp_ready(rt2x00dev)))
> return -EIO;
>
> + rt2800_init_bbp(rt2x00dev);
> rt2800_init_rfcsr(rt2x00dev);
>
> if (rt2x00_is_usb(rt2x00dev) &&
> --
> 1.7.4.4
>
>
> _______________________________________________
> users mailing list
> [email protected]
> http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
------------------------------
Message: 2
Date: Thu, 16 May 2013 16:42:15 +0200
From: Helmut Schaa <[email protected]>
To: "[email protected]" <[email protected]>
Cc: rt2x00 Users List <[email protected]>
Subject: Re: [rt2x00-users] [RFC 01/32] rt2800: make rt2800_init_bbp
return void
Message-ID:
<cagxe3d_rmnfxrm9sk-4m_+tuevdimmswxoh80q1wmiaav5t...@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
On Thu, May 16, 2013 at 4:41 PM, Helmut Schaa
<[email protected]> wrote:
> On Wed, May 8, 2013 at 9:49 PM, <[email protected]> wrote:
>> From: Stanislaw Gruszka <[email protected]>
>>
>> This function can not fail, we always return 0.
>
> Fine with me.
> Any special reason why you replace -EACCES; with -EIO?
My fault, all correct!
------------------------------
Message: 3
Date: Thu, 16 May 2013 16:47:38 +0200
From: Helmut Schaa <[email protected]>
To: "[email protected]" <[email protected]>
Cc: rt2x00 Users List <[email protected]>
Subject: Re: [rt2x00-users] [RFC 00/32] BBP initialization split
Message-ID:
<CAGXE3d8Zo_JTkvpvH4Y=4RjC-h0=oYWBksDy=wj+pnjj0an...@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
On Wed, May 8, 2013 at 9:49 PM, <[email protected]> wrote:
> This series spits big and messy rt2800_init_bbp() procedure into small
> per chip (or few similar chips) subroutines.
Awesome, I really like this change :D
I had a quick glance at the patchset and without doing an in-depth
review it looks fine to me.
So, if you want to you can add my
Acked-by: Helmut Schaa <[email protected]>
------------------------------
Subject: Digest Footer
_______________________________________________
users mailing list
[email protected]
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
------------------------------
End of users Digest, Vol 51, Issue 17
*************************************
