Send users mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of users digest..."
Today's Topics:
1. Re: [PATCH 0/3] rt2x00: rt2800: prepare for three-chain
device support (Stanislaw Gruszka)
2. [PATCH] rt2x00: rt2800lib: fix default TX power check for
RT55xx (Gabor Juhos)
3. Re: [PATCH] rt2x00: rt2800lib: fix default TX power check for
RT55xx (Gertjan van Wingerde)
----------------------------------------------------------------------
Message: 1
Date: Tue, 25 Jun 2013 21:18:51 +0200
From: Stanislaw Gruszka <[email protected]>
To: Gabor Juhos <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [rt2x00-users] [PATCH 0/3] rt2x00: rt2800: prepare for
three-chain device support
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
On Mon, Jun 24, 2013 at 09:09:02PM +0200, Gabor Juhos wrote:
> I'm testing these patches on a Linksys AE3000 device which also uses the
> RT3573
> chip. I have an almost complete patch-set which allows me to use the device in
> STA and in AP mode, however I still have to resolve a few problems.
Cool, waiting for the post ... :-)
Stanislaw
------------------------------
Message: 2
Date: Tue, 25 Jun 2013 22:57:29 +0200
From: Gabor Juhos <[email protected]>
To: John Linville <[email protected]>
Cc: [email protected], [email protected],
[email protected], Gabor Juhos <[email protected]>,
[email protected], #@arrakis.dune.hu
Subject: [rt2x00-users] [PATCH] rt2x00: rt2800lib: fix default TX
power check for RT55xx
Message-ID: <[email protected]>
The code writes the default_power2 value into the TX field
of the RFCSR50 register, however the condition in the if
statement uses default_power1. Due to this, wrong TX power
value might be written into the register.
Use the correct value in the condition to fix the issue.
Compile tested only.
Signed-off-by: Gabor Juhos <[email protected]>
Cc: [email protected] # 3.10
---
John,
This is for 3.11. Even though the original code is introduced in
3.10-rc2 phase, but it is already too late to fix it in 3.10.
-Gabor
---
drivers/net/wireless/rt2x00/rt2800lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c
b/drivers/net/wireless/rt2x00/rt2800lib.c
index 25f7dbe..1f80ea5 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -2392,7 +2392,7 @@ static void rt2800_config_channel_rf55xx(struct
rt2x00_dev *rt2x00dev,
rt2800_rfcsr_write(rt2x00dev, 49, rfcsr);
rt2800_rfcsr_read(rt2x00dev, 50, &rfcsr);
- if (info->default_power1 > power_bound)
+ if (info->default_power2 > power_bound)
rt2x00_set_field8(&rfcsr, RFCSR50_TX, power_bound);
else
rt2x00_set_field8(&rfcsr, RFCSR50_TX, info->default_power2);
--
1.7.10
------------------------------
Message: 3
Date: Tue, 25 Jun 2013 23:08:02 +0200
From: Gertjan van Wingerde <[email protected]>
To: Gabor Juhos <[email protected]>
Cc: "[email protected]" <[email protected]>,
"[email protected]" <[email protected]>,
"[email protected]" <[email protected]>,
Gabor
Juhos <[email protected]>, "[email protected]"
<[email protected]>, "#@arrakis.dune.hu" <#@arrakis.dune.hu>
Subject: Re: [rt2x00-users] [PATCH] rt2x00: rt2800lib: fix default TX
power check for RT55xx
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Sent from my iPad
On 25 jun. 2013, at 22:57, Gabor Juhos <[email protected]> wrote:
> The code writes the default_power2 value into the TX field
> of the RFCSR50 register, however the condition in the if
> statement uses default_power1. Due to this, wrong TX power
> value might be written into the register.
>
> Use the correct value in the condition to fix the issue.
>
> Compile tested only.
>
> Signed-off-by: Gabor Juhos <[email protected]>
> Cc: [email protected] # 3.10
Good catch. Thanks for spotting it.
Acked-by: Gertjan van Wingerde <[email protected]>
> ---
> John,
>
> This is for 3.11. Even though the original code is introduced in
> 3.10-rc2 phase, but it is already too late to fix it in 3.10.
>
> -Gabor
> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c
> b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 25f7dbe..1f80ea5 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -2392,7 +2392,7 @@ static void rt2800_config_channel_rf55xx(struct
> rt2x00_dev *rt2x00dev,
> rt2800_rfcsr_write(rt2x00dev, 49, rfcsr);
>
> rt2800_rfcsr_read(rt2x00dev, 50, &rfcsr);
> - if (info->default_power1 > power_bound)
> + if (info->default_power2 > power_bound)
> rt2x00_set_field8(&rfcsr, RFCSR50_TX, power_bound);
> else
> rt2x00_set_field8(&rfcsr, RFCSR50_TX, info->default_power2);
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
------------------------------
Subject: Digest Footer
_______________________________________________
users mailing list
[email protected]
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
------------------------------
End of users Digest, Vol 52, Issue 17
*************************************
