Hi Bertrand, I finally found some time this weekend to attempt to execute the sample test modules against a fresh CQ 5.4 instance. I set up a local project and created branches of the sample tests, failing tests, and integration tests modules to remove the launchpad-dependent functionality from their pom.xml files.
As I worked through the various tests that are executed by the sample integration tests module, I discovered three places in the runtime libraries where a SlingClient wasn't passing credentials along with a request, which was causing various tests to fail. I've attached a patch file with changes I made to use the admin credentials in those three places, in addition to the changes I made to the HttpRequest class to work around the NPE I mentioned before. I was able to execute the sample integration tests against CQ 5.4 without any failures after integrating and deploying these changes to my local instance. Please let me know if there are any other steps I need to follow or if there is any other information you would like me to provide. Thanks, Mark Adamcin Acquity Group On Fri, Apr 29, 2011 at 12:25 AM, Bertrand Delacretaz < [email protected]> wrote: > Hi Mark, > > On Thu, Apr 28, 2011 at 6:04 PM, Mark Adamcin <[email protected]> wrote: > > The output from a direct request to the test URL is successful: > > > > curl -u admin:admin > > http://localhost:4502/apps/geometrixx/test-content/example.test.txt > > TEST_PASSED > > ok > > > > > It looks like there is a NullPointerException being thrown by the > > ParameterSupport class when it tries to iterate over the request > parameter > > map entries when TestAllPaths attempts to render the test resource. It > seems > > like there should be a null check in the ParameterSupport class to > prevent > > the NPE, but perhaps it might be a good idea to return an empty map > instead > > of null in the > > org.apache.sling.junit.scriptable.HttpRequest.getParameterMap() > > implemententation. > > > > Is this something I could submit a patch for?... > > Yes, makes sense, thanks for your analysis! > > -Bertrand >
