Wolfgang Sourdeau wrote:
As mentionned in another answer, those options are indeed stored in the database metadata sdb file. I could change the code to default to "true". I didn't initially because the performance is immediately impacted when you have a couple of events in your calendar.

Thanks Wolfgang for your reply, and Luca for your patch.

As for the performance reasons, I had figured that was probably the case. However, from an administrative standpoint, it's far less cumbersome to have things default to their previous behavior and give users the option to toggle the feature for their calendars if they feel they need the performance boost.

We could cater to both sides by introducing a Lightning preference that determines what behavior to choose. This wouldn't enforce a setting on calendars that already have the property set, but would allow administrators to manage how Thunderbird handles the property on calendars when upgrading.

The attached patch does just that, based on Luca's patch.

--

Adam Yearout
[email protected]
--- defaults/preferences/lightning.js.orig      2010-05-04 13:47:13.000000000 
-0700
+++ defaults/preferences/lightning.js   2010-05-11 18:00:48.000000000 -0700
@@ -107,6 +107,11 @@
 // number of visible hours for day and week views
 pref("calendar.view.visiblehours", 9);
 
+// Toggling to "true" will remove events from the Today Pane and hide
+// invitations for calendars that do not have the "showInTodayPane" and
+// "showInvitations" properties specifically set.
+pref("calendar.view.loadfaster", false);
+
 // Do not set this!  If it's not there, then we guess the system timezone
 //pref("calendar.timezone.local", "");
 
--- js/calProviderBase.js.orig  2010-05-04 13:47:13.000000000 -0700
+++ js/calProviderBase.js       2010-05-11 17:55:27.000000000 -0700
@@ -380,7 +380,16 @@
                             ret = Number(ret);
                             break;
                     }
-                }
+                } else {
+                   if (!getPrefSafe("calendar.view.loadfaster", false)) {
+                       switch (aName) {
+                           case "showInTodayPane":
+                           case "showInvitations":
+                               ret = true;
+                               break;
+                       }
+                   }
+               }
             }
             this.mProperties[aName] = ret;
         }
-- 
[email protected]
https://inverse.ca/sogo/lists

Reply via email to