-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi!

To follow-up my previous mail...

Andreas Haumer schrieb:
> Hi!
> 
> I'm running SOGo-1.3.1 successfully on a Linux server for
> some time now. Today I tried to upgrade to SOGO-1.3.2 and/or
> SOGo-1.3.3, but failed with the following compilation error:
> 
> [...]
> make[2]: Entering directory `/work/packages/SOGo-1.3.3/SoObjects/Appointments'
> Making all for wobundle Appointments...
> gcc SOGoEMailAlarmsManager.m -c \
>               -MMD -MP -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_RUNTIME=1 
> -DGNUSTEP_BASE_LIBRARY=1 -D_REENTRANT -fPIC -DDEBUG -fno-omit-frame-pointer 
> -Wall -DGSWARN -DGSDIAGNOSE -Wno-import -g -march=i586 -fno-strict-aliasing 
> -fgnu-runtime -fconstant-string-class=NSConstantString -I.. -I../.. 
> -I../../SOPE -I../../SOPE/ -I. -I/home/andreas/GNUstep/Library/Headers 
> -I/usr/GNUstep/Local/Library/Headers -I/usr/GNUstep/System/Library/Headers \
>                -o obj/Appointments.obj/SOGoEMailAlarmsManager.m.o
> SOGoEMailAlarmsManager.m:321: error: conflicting types for `alarmNbr'
> SOGoEMailAlarmsManager.m:321: error: previous declaration of `alarmNbr'
> make[3]: *** [obj/Appointments.obj/SOGoEMailAlarmsManager.m.o] Error 1
> [...]
> 
> I get the same error for both SOGo-1.3.2 and SOGo-1.3.3, but
> not with SOGo-1.3.1 (which does not contain this file)
> SOPE-1.3.2 and SOPE-1.3.3 compile just fine.
> 

I did some further investigation into the issue and I think I found the
bug: it's not in SOGoEMailAlarmsManager.m but rather in the header file
SOPE/GDLContentStore/GCSAlarmsFolder.h

As I said I'm not a Objective-C programmer, but to me it seems
in the declaration of method(?) "writeRecordForEntryWithCName"
there is a parameter mis-named: alarmNbr is used twice as parameter
name, seemingly with different types (NSNumber * vs. NSCalendarDate *)

When I apply the following patch:

andr...@test5:/work/packages/SOGo-1.3.3/SOPE/GDLContentStore {1066} % diff -u 
GCSAlarmsFolder.h~ GCSAlarmsFolder.h
- --- GCSAlarmsFolder.h~  2010-10-19 18:35:28.000000000 +0200
+++ GCSAlarmsFolder.h   2010-10-22 15:38:38.000000000 +0200
@@ -56,7 +56,7 @@
                                forUID: (NSString *) uid
                          recurrenceId: (NSCalendarDate *) recId
                           alarmNumber: (NSNumber *) alarmNbr
- -                         andAlarmDate: (NSCalendarDate *) alarmNbr;
+                         andAlarmDate: (NSCalendarDate *) alarmDate;

 - (void) deleteRecordForEntryWithCName: (NSString *) cname
                       inCalendarAtPath: (NSString *) path;


SOGo-1.3.3 compiles fine (though I haven't run it yet. I also have not
tested the patch for SOGo-1.3.2, yet).

Could anyone confirm this (or correct me, if I'm wrong), please?

One question remains: why does this construct compile for anybody else but me?

Thanks!

- - andreas

- --
Andreas Haumer                     | mailto:andr...@xss.co.at
*x Software + Systeme              | http://www.xss.co.at/
Karmarschgasse 51/2/20             | Tel: +43-1-6060114-0
A-1100 Vienna, Austria             | Fax: +43-1-6060114-71
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iD8DBQFMwZYFxJmyeGcXPhERAgqDAKCMFgjKUMXWxg2LVgrAlgR77ZtOaQCfU9Kx
xxQFdIR3OFtWn01LGYM54yo=
=GUsl
-----END PGP SIGNATURE-----
-- 
users@sogo.nu
https://inverse.ca/sogo/lists

Reply via email to