On 26/03/16 16:27, Jesús García Sáez ([email protected]) wrote:


On Fri, Mar 25, 2016 at 11:44 AM, Andrey Cherepanov <[email protected] <mailto:[email protected]>> wrote:

    Can anybody compile openchange with samba 4.4.0? Now samba contains

    commit 218f96f2bf10f7f03ec964c4515f6e248fc31ad8
    Author: Jelmer Vernooij <[email protected] <mailto:[email protected]>>
    Date:   Mon Jan 4 00:56:10 2016 +0000

        libcli: Make headers for private libraries private.

        Signed-off-by: Jelmer Vernooij <[email protected]
    <mailto:[email protected]>>
        Reviewed-By: Andrew Bartlett <[email protected]
    <mailto:[email protected]>>
        Reviewed-By: Stefan Metzmacher <[email protected]
    <mailto:[email protected]>>

    ldap_ndr.h is now private header and is not available for openchange:
    Compiling libmapiadmin/mapiadmin_user.c with -fPIC
    libmapiadmin/mapiadmin_user.c:33:22: fatal error: ldap_ndr.h: No
    such file or directory

    OpenChange 2.4-zentyal22 is still use it:
    $ git grep 'ldap_ndr.h>' | cat
    libmapiadmin/mapiadmin_user.c:#include <ldap_ndr.h>
    mapiproxy/servers/default/emsmdb/emsmdbp.c:#include <ldap_ndr.h>

    I try to subscribe [email protected]
    <mailto:[email protected]> and create issue on
    https://github.com/zentyal/openchange but without any result.

-- Andrey Cherepanov
    [email protected] <mailto:[email protected]>
-- [email protected] <mailto:[email protected]>
    https://inverse.ca/sogo/lists




You don't need to remove that commit from samba, you can use something like this https://github.com/blaxter/openchange/commit/5f5783711d2c2496a824e66c8aa439781cac67fa and it will compile just fine
--
[email protected]
https://inverse.ca/sogo/lists

OK, I can now tell you, do not use Samba 4.1.18 with Openchange unless you can backport the badlock patches or if Openchange does so, Samba will not backport these packages.

There are various problems covered by the patches, chiefly there is a risk of 'man in the middle' attacks.

Rowland
--
[email protected]
https://inverse.ca/sogo/lists

Reply via email to