Troels Walsted Hansen wrote:
You're perfectly right, of course. I did notice this problem, but I wasn't aware of headers_ham so I didn't find a way to fix it. In fact I was wondering about the legality of manipulating $permsgstatus->{main}->{conf} from a plugin. Is it considered bad practice?
As far as I know it's the only way, although I haven't really looked into it. Not much to go by example wise since plugins are new for v3.
I was expecting a $permsgstatus->add_header() function or similar, and when I didn't find I grepped the SA source until I found an alternative way to add headers to the mail.
That would make sense as it would prevent you from overwriting another plugins (arbitrarily defined / self chosen) headers. You make want to make a request in the bugzilla at bugzilla.spamassassin.org if nobody else on the list has a better idea.
Thanks for your fix!
No problem.
Daryl