On Thu, 10 Dec 2020, Benoit Branciard wrote:

Have there been any changes to the __PDS_FROM_2_EMAILS rule recently on 3.004002 branch ?

Yes. I took another look at it prompted by the recent many-froms discussion and did a little tuning.

Since latest update this night, we got significantly more matches of meta rule PDS_FROM_2_EMAILS than previously, and for at least a dozen of them, the rule triggered despite the fact that both addresses (in from text and address) were strictly identical, like this :

From: "my.u...@univ-paris1.fr" <my.u...@univ-paris1.fr>

It *should not* be doing that. I have test cases in my dev environment like that and it doesn't hit them, but I will check again.

Until now I expected this rule to match *only* if from text and address contained *different* addresses...

Correct.

my /var/lib/spamassassin/3.004002/updates_spamassassin_org/72_active.cf contains :

header __PDS_FROM_2_EMAILS From =~ /(?:\W|^)([\w+.-]+\@[\w.-]+\.\w\w++)(?:[^\n\w<]{0,80})?<(?!\1)[^\n\s]*\@/i

The "(?!\1)" is intended to prevent that.

...okay, I found the problem. None of my tests had a username with a period. Fixing.

--
 John Hardin KA7OHZ                    http://www.impsec.org/~jhardin/
 jhar...@impsec.org                         pgpk -a jhar...@impsec.org
 key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C  AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
 5 days until Bill of Rights day

Reply via email to