Re: TxRep does not read setting|default value

[Tomohiro Hosaka]

Hello.

Thanks for the reply.
Added txrep_dilution_factor 0.98 to 
/usr/local/etc/mail/spamassassassin/local.cf

 340   push (@cmds, {
 341     setting     => 'txrep_dilution_factor',
 342     default     => 0.98,
 343     type        => $Mail::SpamAssassin::Conf::CONF_TYPE_NUMERIC,
 344     code        => sub {
 345         my ($self, $key, $value, $line) = @_;
 346         if ($value < 0.7 || $value > 1.0) {return 
$Mail::SpamAssassin::Conf::INVALID_VALUE;}
 347         warn $self;
 348         use Carp qw(cluck);
 349         cluck "This is how we got here!";
 350         $self->{txrep_dilution_factor} = $value;
 351     }
 352   });


Mail::SpamAssassin::Conf=HASH(0x8577b09d8) at 
/usr/local/lib/perl5/site_perl/IO/All.pm line 148.
This is how we got here! at 
/usr/local/lib/perl5/site_perl/Mail/SpamAssassin/Plugin/TxRep.pm line 
349.
        
Mail::SpamAssassin::Plugin::TxRep::__ANON__(Mail::SpamAssassin::Conf=HASH(0x8577b09d8), 
"txrep_dilution_factor", 0.98, "txrep_dilution_factor 0.98") called at 
/usr/local/lib/perl5/site_perl/Mail/SpamAssassin/Conf/Parser.pm line 437
        
Mail::SpamAssassin::Conf::Parser::parse(Mail::SpamAssassin::Conf::Parser=HASH(0x84e63dbe8), 
"file start (pre_config_text)\x{a}\x{a}file end 
(pre_config_text)\x{a}file"..., 0) called at 
/usr/local/lib/perl5/site_perl/Mail/SpamAssassin/Conf.pm line 5033
        
Mail::SpamAssassin::Conf::parse_rules(Mail::SpamAssassin::Conf=HASH(0x8577b09d8), 
"file start (pre_config_text)\x{a}\x{a}file end 
(pre_config_text)\x{a}file"...) called at 
/usr/local/lib/perl5/site_perl/Mail/SpamAssassin.pm line 1792
        Mail::SpamAssassin::init(Mail::SpamAssassin=HASH(0x8577d42a0), 
1) called at /usr/local/lib/perl5/site_perl/Mail/SpamAssassin.pm line 
709
        
Mail::SpamAssassin::init_learner(Mail::SpamAssassin=HASH(0x8577d42a0), 
HASH(0x84e63d930)) called at /root/myops/script/sa_scan.pl line 336
        main::new_sa() called at /root/myops/script/sa_scan.pl line 145
        main::run(main=HASH(0x82f4515b8)) called at 
/root/myops/script/sa_scan.pl line 386

$self is Mail::SpamAssassin::Conf=HASH(0x8577b09d8) here.
It is not Mail::SpamAssassin::Plugin::TxRep=HASH(...).

I tried the bottom and it was the same.

--- 
/usr/local/lib/perl5/site_perl/Mail/SpamAssassin/Plugin/TxRep.pm.orig    
   2024-05-30 22:22:55.412407000 +0900
+++ /usr/local/lib/perl5/site_perl/Mail/SpamAssassin/Plugin/TxRep.pm    
2024-05-30 22:23:37.990091000 +0900
@@ -1675,6 +1675,7 @@

   # performing the dilution aging correction
   if (defined $self->total() && defined $self->count() && 
$self->count() > 0 && defined $self->{txrep_dilution_factor}) {
+    die; # It will never be processed here.
     my $diluted_total =
         ($self->count() + 1) *
         ($self->{txrep_dilution_factor} * $self->total() + $score) /

Thanks.

2024-05-30 21:38 に Bill Cole さんは書きました:
On 2024-05-30 at 03:58:18 UTC-0400 (Thu, 30 May 2024 16:58:18 +0900)
Tomohiro Hosaka <boku...@bokut.in>
is rumored to have said:

Hello.

The code seems to be wrong.

I do not believe that to be so. See lines 340-347 in TxRep.pm.