Awesome! I'll take a look at it next week.
On Wed, Sep 1, 2021 at 7:35 AM pico.dev <pico....@gmail.com> wrote: > Thanks Tim. > > Updated to use Jetty 10 and Java 11. > > El mié, 1 sept 2021 a las 4:07, D Tim Cummings > (<t...@triptera.com.au.invalid>) > escribió: > > > Thanks pico > > > > I had a quick look and see that you are targeting java 8 and jetty 9.4. > > I think we should be targeting java 11 and jetty 10 at least. The > > quickstart helps new users get familiar with tapestry and old users see > > what is required to run tapestry on the latest java and jetty. I > > remember when I first started with tapestry how frustrating it was for > > me to have to learn really old versions of jetty just to get sample code > > to run. Then my first task was to translate everything to new versions > > of jetty, not knowing if it was even possible. Now we should say that > > tapestry doesn't work with jetty 11 so we are providing an example with > > jetty 10. > > > > Thanks for all your work. I will keep testing. > > > > Tim > > > > On 31/8/21 20:36, pico.dev wrote: > > > Hello, > > > > > > I created this issue https://issues.apache.org/jira/browse/TAP5-2690 > > Update > > > quickstart to make Spring Boot optional. > > > > > > I attached a patch in the issue and a summary with the main changes > > > performed to the quickstart. > > > > > > Give a look and a test, if something should be changed leave a comment > > and > > > I will do the change. > > > > > > Regards, > > > > > > El vie, 27 ago 2021 a las 7:52, pico.dev (<pico....@gmail.com>) > > escribió: > > > > > >> Hello, > > >> > > >> Just to say that I will start to work on updating quickstat to make > > spring > > >> boot optional. Give me some days, I will come with a patch. > > >> > > >> Regards, > > >> > > >> El mar, 10 ago 2021 a las 23:36, Thiago H. de Paula Figueiredo (< > > >> thiag...@gmail.com>) escribió: > > >> > > >>> On Thu, Aug 5, 2021 at 10:02 PM D Tim Cummings > > >>> <t...@triptera.com.au.invalid> > > >>> wrote: > > >>> > > >>>> Hi Thiago > > >>>> > > >>> Hello! > > >>> > > >>> > > >>>> I believe pico.dev is waiting for confirmation that you would like > > the > > >>>> quickstart app reverted to jetty. > > >>> > > >>> I'm sorry I overlooked this. I prefer Quickstart to be as simple as > > >>> possible, so I believe Jetty is the way to go. SpringBoot is better > > left > > >>> being optional. > > >>> > > >>> > > >>>> Personally I think it is great there > > >>>> is a quickstart using springboot, but it should be in addition to > the > > >>>> quickstart using jetty, not replacing it. Also it should come with > > >>>> instructions how to use it. > > >>>> > > >>> I also agree with this. > > >>> > > >>> > > >>>> I have just tried quickstart again recently and the three issues > > listed > > >>>> in my first email below, still exist. > > >>>> > > >>>> *An additional problem facing new users on the getting started page* > > >>>> > > >>>> Getting started https://tapestry.apache.org/getting-started.html > > >>> suggests > > >>>> mvn archetype:generate -DarchetypeCatalog= > http://tapestry.apache.org > > >>>> > > >>>> However this no longer works on version 3 or later of the > > >>>> maven-archetype-plugin. This has been flagged as issue > > >>>> https://issues.apache.org/jira/projects/TAP5/issues/TAP5-2579 . I > > >>>> suggest changing web page to use the command > > >>>> > > >>>> mvn archetype:generate -Dfilter=org.apache.tapestry:quickstart > > >>>> > > >>>> and then you could close that issue. If someone could give me edit > > >>>> privileges on the getting started page I would be happy to do that. > > >>>> > > >>> Thanks for spotting that and volunteering for fixing it! I just fixed > > it > > >>> myself, but it takes some time for the fix to be replicated to the > > site. > > >>> > > >>> Thank you! > > >>> > > >>>> Thanks > > >>>> > > >>>> Tim > > >>>> > > >>>> On 1/5/21 17:17, pico.dev wrote: > > >>>>> Hi! > > >>>>> > > >>>>> Sorry for the inconvenience. > > >>>>> > > >>>>> If Spring Boot is not desired in the app generated by quickstart, I > > >>> could > > >>>>> try to provide a new patch to remove it if you wish, I hope as soon > > >>> as I > > >>>>> can, just confirm me and I start doing the changes. > > >>>>> > > >>>>> Regards, > > >>>>> > > >>>>> El vie, 30 abr 2021 a las 22:43, Thiago H. de Paula Figueiredo (< > > >>>>> thiag...@gmail.com>) escribió: > > >>>>> > > >>>>>> Hello! > > >>>>>> > > >>>>>> Thank you very much for spotting and warning us about these > issues. > > >>>>>> > > >>>>>> You shouldn't need to use Spring Boot. The archetype needs to be > > >>> fixed. > > >>>>>> On Sat, Apr 24, 2021 at 9:00 PM D Tim Cummings > > >>>> <t...@triptera.com.au.invalid > > >>>>>> wrote: > > >>>>>> > > >>>>>>> I have tried the instructions at > > >>>>>>> https://tapestry.apache.org/getting-started.html using Tapestry > > >>> 5.7.2 > > >>>>>>> archetype. > > >>>>>>> > > >>>>>>> 1. The code produced by 5.7.2 archetype uses 5.6 packages > > >>>>>>> org.apache.tapestry5.services.Request, RequestFilter, > > >>> RequestHandler, > > >>>>>>> Response so it won't compile. > > >>>>>>> > > >>>>>>> As there were only four to be fixed I manually changed them in > > >>>>>>> com.example.newapp.services.AppModule.java to > > >>>>>>> > > >>>>>>> import org.apache.tapestry5.http.services.Request; > > >>>>>>> import org.apache.tapestry5.http.services.RequestFilter; > > >>>>>>> import org.apache.tapestry5.http.services.RequestHandler; > > >>>>>>> import org.apache.tapestry5.http.services.Response; > > >>>>>>> > > >>>>>>> 2. Instructions say use 'mvn jetty:run' but there is no jetty > > plugin > > >>>>>>> defined in the pom so this doesn't work despite the nice screen > > shot > > >>>>>>> showing it working with 5.7.2. > > >>>>>>> > > >>>>>>> 3. I ran 'mvn spring-boot:run' and this ran successfully. > However, > > >>> one > > >>>>>>> of the reasons I was trying the archetype was because I was > getting > > >>> a > > >>>>>>> lot of duplicate jar warnings in the project I was migrating to > > >>> 5.7.2. > > >>>>>>> Maybe spring-boot solves this problem by not copying duplicates > > into > > >>>> its > > >>>>>>> uber jar. Do I need to convert my existing project to include > > >>>>>>> spring-boot for building a war? > > >>>>>>> > > >>>>>>> Thanks > > >>>>>>> > > >>>>>>> Tim > > >>>>>>> > > >>>>>>> > > >>>>>>> > > >>> --------------------------------------------------------------------- > > >>>>>>> To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > > >>>>>>> For additional commands, e-mail: users-h...@tapestry.apache.org > > >>>>>>> > > >>>>>>> > > >>>>>> -- > > >>>>>> Thiago > > >>>>>> > > >>> > > >>> -- > > >>> Thiago > > >>> > > > > > -- Thiago
