Antonio:

I defer to your judgement since you know the code
much better than I do.

I appreciate your willingness to work on this
issue.

Thank you,
        Neil 

--
Neil Aggarwal, (832)245-7314, www.JAMMConsulting.com
Eliminate junk email and reclaim your inbox.
Visit http://www.spammilter.com for details.

-----Original Message-----
From: Antonio Petrelli [mailto:[EMAIL PROTECTED] 
Sent: Monday, September 03, 2007 10:46 AM
To: [email protected]
Subject: Re: Improvement: Do not create sessions in
ServletTilesRequestContext

2007/9/3, Neil Aggarwal <[EMAIL PROTECTED]>:
>
> Antonio:
>
> Are you suggesting to create a ServletSessionScopeMap
> even when there is no session?
>
> HttpServletRequest.getSession(false) returns null when
> there is no session.  I think we should try to follow
> that.



It will be followed, but inside ServletSessionScopeMap.
The map will be created anyway, but it will be empty. But when someone adds
an attribute, it will be created. Returning a null Map, IMHO, prevents users
from creating their own session-scoped attributes.
If it is still not clear, I will try to create a patch and post it in the
TILES-207 issue, so we can discuss it.

Antonio

Reply via email to