On 18/11/2019 04:36, jonmcalexan...@wellsfargo.com.INVALID wrote: > Oh yippee. Another release. :-D
I'm not sure how to take that. My impression is that you think another release is a bad thing. My expectation was that regular releases would be viewed as a good thing. I apologise if I have misinterpreted your comment but, if I haven't, could you explain why another release is a bad thing? > Do you have an ETA on 8.5.49 Mark? Voting started yesterday. Votes typically run for 72 hours. While we can use shorter / longer voting periods, I'm expecting this one to be the typical 72 hours. Assuming the vote passes, I'll move everything to the release area. It then takes ~24 hours for the mirrors to pick up the release and we announce shortly afterwards. That said, the actual bits don't change. So you can get a copy of 8.5.49 whenever you like and can consider it released as soon as the VOTE passes on the dev@ list. I'd expect that some time Wednesday evening / Thursday morning (UTC). Mark > > > Dream * Excel * Explore * Inspire > Jon McAlexander > Asst Vice President > > Middleware Product Engineering > Enterprise CIO | Platform Services | Middleware | Infrastructure Solutions > > Upcoming PTO: 11/8, 11/11, 11/15, 11/22, 11/28, 11/29, 12/2, 12/6, 12/13, > 12/20 – 12/31 > > 8080 Cobblestone Rd | Urbandale, IA 50322 > MAC: F4469-010 > Tel 515-988-2508 | Cell 515-988-2508 > > jonmcalexan...@wellsfargo.com > > > This message may contain confidential and/or privileged information. If you > are not the addressee or authorized to receive this for the addressee, you > must not use, copy, disclose, or take any action based on this message or any > information herein. If you have received this message in error, please advise > the sender immediately by reply e-mail and delete this message. Thank you for > your cooperation. > > -----Original Message----- > From: Mark Thomas <ma...@apache.org> > Sent: Sunday, November 17, 2019 11:01 AM > To: users@tomcat.apache.org > Subject: Re: Tomcat 8.5.48: NullPointerException in > ApplicationMapping.getHttpServletMapping() > > On 16/11/2019 22:08, Adam Rauch wrote: >> While testing 8.5.48, we now see NullPointerExceptions when our >> ImageServlet code attempts to forward a request to a new location. In >> 8.5.47, the code works fine. > > Thanks for reporting this. I can see what the problem is. > > I updated the servlet4preview API in 8.5.x to align it with what was released > in Servlet 4 (some names changed). As part of that I aligned the 8.5.x > implementation code with 9.0.x. That removed a null check that 8.5.x needs. > I'll cancel the 8.5.48 vote, get that fixed and roll an > 8.5.49 release. > > Mark > > >> >> A simplified version of our code: >> >> public void sendResource(HttpServletRequest request, >> HttpServletResponse response) throws IOException, ServletException >> { >> request.getRequestDispatcher(getForwardLocation(request)).forward(requ >> est, >> response); >> } >> >> The NPE stack trace we see: >> >> java.lang.NullPointerException >> at >> org.apache.catalina.core.ApplicationMapping.getHttpServletMapping(Appl >> icationMapping.java:36) >> >> at >> org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDi >> spatcher.java:380) >> >> at >> org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDisp >> atcher.java:316) >> >> at >> org.labkey.api.settings.TemplateResourceHandler.sendResource(TemplateR >> esourceHandler.java:202) >> >> at >> org.labkey.api.attachments.ImageServlet.service(ImageServlet.java:72) >> at >> javax.servlet.http.HttpServlet.service(HttpServlet.java:741) >> at >> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appli >> cationFilterChain.java:231) >> >> at >> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFi >> lterChain.java:166) >> >> at >> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) >> >> Let me know if you'd like me to open a Bugzilla and/or provide more >> context. >> >> Thanks, >> Adam >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: users-h...@tomcat.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org