-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Remon,
On 10/19/2011 12:23 PM, Remon Sadikni wrote: > Hi Chris, >> >> If you overrode the process() method (and I'm sure you changed >> other things, too, since the variable "allows" is not part of >> RequestFilterValve), then you really aren't getting anything by >> extending RequestFilterValve. > > but "allows" is part of RequestFilterValve. Not in the current trunk. Your code expects the "allows" variable to be of type String[], and no such variable exists in RequestFilterValve. > I only extended this class. I took the same invoke() method as > RequestAddrValve, so that I get the IP-address of the user: > > public void invoke(Request request, Response response) throws > IOException, ServletException { > process(request.getRequest().getRemoteAddr(), request, response); > } > > and overwrote the process method to react on this IP address. Right: the point of the RequestFilterValve is that you don't have to override the process() method. Overriding it kind of defeats the purpose of the class, because it really doesn't have any other methods other than the accessors and mutators for the 'deny' and 'allow' properties. - -chris -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6fEtAACgkQ9CaO5/Lv0PAVagCdGCDoraUl41tI7H9hgKxIPkqU AvwAoLV9OW95mDaPVXL7vibCfWo5Yokj =4oGY -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org