On Tue, Jan 29, 2013 at 7:42 PM, David Blevins <david.blev...@gmail.com>wrote:
> > On Jan 29, 2013, at 4:04 PM, "Howard W. Smith, Jr." < > smithh032...@gmail.com> wrote: > > > On Tue, Jan 29, 2013 at 6:08 PM, Konstantin Kolinko > > <knst.koli...@gmail.com>wrote: > > > >> 2013/1/30 Caldarale, Charles R <chuck.caldar...@unisys.com>: > >>>> From: Howard W. Smith, Jr. [mailto:smithh032...@gmail.com] > >>>> Subject: Latest-version TomEE 1.5.2-SNAPSHOT (Tomcat 7.0.34?) just > died > >> on me, nothing in server logs > >>> > >>>> Sending this to tomee/openejb and tomcat user mailing lists. > >>> > >>> Cross-posting is really frowned upon. > >>> > >>>> Jan 29, 2013 10:27:25 AM org.apache.catalina.core.StandardWrapperValve > >> event > >>>> SEVERE: Servlet.service() for servlet [Push Servlet] in context with > >> path > >>>> [/mcmsweb] threw exception > >>>> java.lang.NumberFormatException: For input string: "(TomEE)/7" > >>>> at java.lang.NumberFormatException.forInputString(Unknown Source) > >>>> at java.lang.Integer.parseInt(Unknown Source) > >>>> at java.lang.Integer.valueOf(Unknown Source) > >>>> at > >> > org.atmosphere.container.Tomcat7CometSupport.bz51881(Tomcat7CometSupport.java:141) > >>> > >>> Sure looks like an Atmosphere problem from here... > >>> > >> > >> +1. > >> > >> > >> > https://github.com/Atmosphere/atmosphere/blob/master/modules/cpr/src/main/java/org/atmosphere/container/Tomcat7CometSupport.java#L129 > >> > >> That "bz51881" method... an example of what you should never do... > >> > >> It tries to parse a version string to "workaround" a bug that was > >> properly fixed more than a year ago, and fails horribly. > >> > >> It is a normal practice to modify the "server info" value, e.g. [1]. > >> It is useless to rely on it. It is no wonder that the one used by > >> TomEE is different from Tomcat. > >> > >> [1] http://tomcat.apache.org/tomcat-7.0-doc/security-howto.html#Valves > >> > >> > >> Best regards, > >> Konstantin Kolinko > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > >> For additional commands, e-mail: users-h...@tomcat.apache.org > >> > >> > > TomEE committers, per Konstantin's response above, can you let me know, > if > > this is TomEE or Atmosphere issue? > > Looks like an Atmosphere issue. It's basically doing: > > String[] tomcatVersion = > config.getServletContext().getServerInfo().substring(14).split("\\."); > > The getServerInfo() method was updated to add "(TomEE)" in there so people > can have more info on the flavor of Tomcat they're using. > > > -David > > Has there been any changes with TomEE 1.5.2-SNAPSHOT between 2013-01-14 and 2013-01-28 that might be related to this? I'm asking, because I just reverted to an earlier version of Atmosphere (1.0.6), and the problem is still occurring. I went back in time and looked at the log files in tomee/logs, and this error really only started happening 'after' I started using the latest TomEE 1.5.2-SNAPSHOT as I reported in OP. :( Even though I informed Atmosphere of any/all details (and responses from tomcat and tomee) [1], I am thinking about reverting to the previous version of TomEE 1.5.2-SNAPSHOT (2013-01-14) that has been running, perfectly, without this issue. After reverting to Atmosphere 1.0.6 (few hours ago) and running latest TomEE 1.5.2-SNAPSHOT, I saw this exception in localhost log in tomee/logs (below). :( Jan 29, 2013 8:52:35 PM org.apache.catalina.core.StandardWrapperValve event SEVERE: Servlet.service() for servlet [Push Servlet] in context with path [/mcmsweb] threw exception java.lang.NumberFormatException: For input string: "(TomEE)/7" at java.lang.NumberFormatException.forInputString(Unknown Source) at java.lang.Integer.parseInt(Unknown Source) at java.lang.Integer.valueOf(Unknown Source) at org.atmosphere.container.Tomcat7CometSupport.bz51881(Tomcat7CometSupport.java:141) at org.atmosphere.container.Tomcat7CometSupport.service(Tomcat7CometSupport.java:114) at org.atmosphere.container.Tomcat7AsyncSupportWithWebSocket.doService(Tomcat7AsyncSupportWithWebSocket.java:63) at org.atmosphere.container.TomcatWebSocketUtil.doService(TomcatWebSocketUtil.java:84) at org.atmosphere.container.Tomcat7AsyncSupportWithWebSocket.service(Tomcat7AsyncSupportWithWebSocket.java:59) at org.atmosphere.cpr.AtmosphereFramework.doCometSupport(AtmosphereFramework.java:1307) at org.atmosphere.cpr.AtmosphereServlet.event(AtmosphereServlet.java:358) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilterEvent(ApplicationFilterChain.java:484) at org.apache.catalina.core.ApplicationFilterChain.doFilterEvent(ApplicationFilterChain.java:377) at org.apache.catalina.core.StandardWrapperValve.event(StandardWrapperValve.java:411) at org.apache.catalina.core.StandardContextValve.event(StandardContextValve.java:146) at org.apache.catalina.valves.ValveBase.event(ValveBase.java:224) at org.apache.catalina.valves.ValveBase.event(ValveBase.java:224) at org.apache.catalina.core.StandardHostValve.event(StandardHostValve.java:256) at org.apache.catalina.valves.ValveBase.event(ValveBase.java:224) at org.apache.catalina.valves.ValveBase.event(ValveBase.java:224) at org.apache.catalina.core.StandardEngineValve.event(StandardEngineValve.java:138) at org.apache.catalina.connector.CoyoteAdapter.event(CoyoteAdapter.java:209) at org.apache.coyote.http11.Http11AprProcessor.event(Http11AprProcessor.java:133) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:585) at org.apache.tomcat.util.net.AprEndpoint$SocketEventProcessor.run(AprEndpoint.java:1867) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) [1] https://groups.google.com/forum/?fromgroups=#!topic/atmosphere-framework/RWuFZfeJu5s
