Also, I just posted something else there...

Okay, I found the following:

https://github.com/Atmosphere/atmosphere/blob/master/modules/cpr/src/main/java/org/atmosphere/cpr/DefaultBroadcaster.java

which has the following code:


    public DefaultBroadcaster(String name, URI uri, AtmosphereConfig config) {

        ...

        s = config.getInitParameter(ApplicationConfig.WRITE_TIMEOUT);
        if (s != null) {
            writeTimeoutInSecond = Integer.valueOf(s);
        }
        noOpsResource = AtmosphereResourceFactory.getDefault().create(config
, "-1");
        logger.info("{} support Out Of Order Broadcast: {}", name,
outOfOrderBroadcastSupported.get());
    }


It seems as though DefaultBroadcaster initialized on every user
HTTP/request, now, when using Atmosphere 1.0.13 snapshot 2013-04-26 with
TomEE 1.6.0 snapshot 2013-04-29 (OpenWebBeans 1.2.0, which features new
interceptor/decorator/bean-manager implementation).



On Tue, Apr 30, 2013 at 12:39 PM, Howard W. Smith, Jr. <
[email protected]> wrote:

> Romain, I really think that you/TomEE/OWB committers should look at this
> since OWB 1.2 has changes in interceptor implementation. Below is my last
> response in that Atmosphere forum topic[1].
>
>
> Jeanfrancois, look at all this below, please.
>
> On Tuesday, April 30, 2013 10:00:36 AM UTC-4, Howard Smith wrote:
>>>
>>> I downloaded new versions of the following,
>>>
>>> tomee 1.6.0 snapshot (2013-04-29, which includes recently-released
>>> OpenWebBeans 1.2.0)
>>>
>>>
>> Okay, I reverted to joda-time 2.0, and I still see this issue.
>> OpenWebBeans 1.2.0 does something with CDI decorator and interceptor
>> stuff/implementation[1]. I wonder if this is interfering with Atmosphere
>> Framework implementation or Atmosphere Framework is not ready for OWB 1.2.0.
>>
>> [1] http://blogs.apache.org/owb/
>>
>>
> I just recognized something. PRIOR to using TomEE 1.6.0 snapshot (which
> features new OWB 1.2.0), Atmosphere (1.0.13 snapshot 2013-04-10)
> initialized with the following in my log file:
>
> Apr 28, 2013 12:20:34 AM org.atmosphere.cpr.AtmosphereFramework interceptor
> INFO: Installed AtmosphereInterceptor Atmosphere LifeCycle.
> Apr 28, 2013 12:20:34 AM org.atmosphere.cpr.AtmosphereFramework
> addAtmosphereHandler
> INFO: Installed AtmosphereHandler
> org.primefaces.push.PrimeAtmosphereHandler mapped to context-path: /*
>
> NOW, since I started using TomEE 1.6.0 snapshot (which features new OWB
> 1.2.0 for interceptors, decorators, etc...), Atmosphere is initialized as
> follows:
>
> Apr 30, 2013 9:37:57 AM org.atmosphere.cpr.AtmosphereFramework interceptor
> INFO: Installed AtmosphereInterceptor Atmosphere LifeCycle.
> Apr 30, 2013 9:37:57 AM org.atmosphere.cpr.DefaultBroadcaster <init>
> INFO: /* support Out Of Order Broadcast: false
> Apr 30, 2013 9:37:57 AM org.atmosphere.cpr.AtmosphereFramework
> addAtmosphereHandler
> INFO: Installed AtmosphereHandler
> org.primefaces.push.PrimeAtmosphereHandler mapped to context-path: /*
>
>
> what has changed between 2013-04-15 and 2013-04-26 versions of Atmosphere
> 1.0.13 snapshot with respect to atmosphere interceptor, lifecycle, etc...?
>
> [1]
> https://groups.google.com/forum/?fromgroups=#!topic/atmosphere-framework/PSaKjlFg8zk
>
>
>
> On Tue, Apr 30, 2013 at 11:04 AM, Howard W. Smith, Jr. <
> [email protected]> wrote:
>
>> hmmm okay/interesting. I'll have to see if this is a logging issue with
>> Atmosphere Framework. Let me try some previous versions of Atmosphere that
>> I downloaded earlier.
>>
>> I definitely want to use TomEE 1.6.0 snapshot (which features OWB
>> 1.2.0)!!! :)
>>
>>
>>
>> On Tue, Apr 30, 2013 at 11:01 AM, Romain Manni-Bucau <
>> [email protected]> wrote:
>>
>>> nowhere normally
>>>
>>> *Romain Manni-Bucau*
>>> *Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
>>> *Blog: **http://rmannibucau.wordpress.com/*<
>>> http://rmannibucau.wordpress.com/>
>>> *LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
>>> *Github: https://github.com/rmannibucau*
>>>
>>>
>>>
>>> 2013/4/30 Howard W. Smith, Jr. <[email protected]>
>>>
>>> > Were there any LOGGER LEVEL changes made in tomee/conf files? Maybe,
>>> this
>>> > is the reason why I am getting extra detail/info in tomee log/console.
>>> >
>>> >
>>> >
>>> > On Tue, Apr 30, 2013 at 10:28 AM, Howard W. Smith, Jr. <
>>> > [email protected]> wrote:
>>> >
>>> > > Atmosphere Framework may offer a web.xml context param that I can
>>> set to
>>> > > 'support out of order broadcast' since OWB 1.2...is in the house. :)
>>> > >
>>> > >
>>> > > On Tue, Apr 30, 2013 at 10:23 AM, Howard W. Smith, Jr. <
>>> > > [email protected]> wrote:
>>> > >
>>> > >> Romain, can you take a look at something for me, please? since I am
>>> > 'now'
>>> > >> using Tomee 1.6.0 snapshot 2013-04-29 (OWB 1.2.0), I think
>>> Atmosphere
>>> > >> Framework is not ready for OWB 1.2.0, because I am getting the
>>> > following in
>>> > >> my netbeans console:
>>> > >>
>>> > >> Apr 30, 2013 10:08:28 AM org.atmosphere.cpr.DefaultBroadcaster
>>> <init>
>>> > >> INFO: /administrator20130430100812 support Out Of Order Broadcast:
>>> false
>>> > >>
>>> > >> I reported this in Atmosphere google group list [1]. Now, I assume
>>> that,
>>> > >> if I revert to a previous version of TomEE 1.6.0 snapshot, I may
>>> not see
>>> > >> this Atmosphere Framework INFO/message in tomee console log.
>>> > >>
>>> > >> Bit more background...last night (early this morning), I downloaded
>>> the
>>> > >> latest Atmosphere 1.0.13 snapshot JARs, deployed to production
>>> server,
>>> > and
>>> > >> I don't see this behavior at all. Please note, I am 'not' yet
>>> running
>>> > TomEE
>>> > >> 1.6.0 (OWB 1.2) on production server yet.
>>> > >>
>>> > >> [1]
>>> > >>
>>> >
>>> https://groups.google.com/forum/?fromgroups=#!topic/atmosphere-framework/PSaKjlFg8zk
>>> > >>
>>> > >>
>>> > >>
>>> > >> On Tue, Apr 30, 2013 at 10:06 AM, Howard W. Smith, Jr. <
>>> > >> [email protected]> wrote:
>>> > >>
>>> > >>> Thanks Romain. Well, I downloaded 2013-04-29 version/JAR of tomee
>>> 1.6.0
>>> > >>> snapshot, and my app works 100%. :)
>>> > >>>
>>> > >>> I 'think' I saw the difference in speed, but then again, this was
>>> > >>> local/dev server instead of production server (which is much faster
>>> > than my
>>> > >>> dev server).
>>> > >>>
>>> > >>>
>>> > >>>
>>> > >>> On Tue, Apr 30, 2013 at 9:50 AM, Romain Manni-Bucau <
>>> > >>> [email protected]> wrote:
>>> > >>>
>>> > >>>> if you have issues maybe that's bugs, if not the code should stay
>>> the
>>> > >>>> same
>>> > >>>>
>>> > >>>> *Romain Manni-Bucau*
>>> > >>>> *Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
>>> > >>>> *Blog: **http://rmannibucau.wordpress.com/*<
>>> > >>>> http://rmannibucau.wordpress.com/>
>>> > >>>> *LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
>>> > >>>> *Github: https://github.com/rmannibucau*
>>> > >>>>
>>> > >>>>
>>> > >>>>
>>> > >>>> 2013/4/30 Howard W. Smith, Jr. <[email protected]>
>>> > >>>>
>>> > >>>> > Question...
>>> > >>>> >
>>> > >>>> > Based on the addition of OWB 1.2.0 to TomEE 1.6.0 snapshot and
>>> the
>>> > >>>> > following,
>>> > >>>> >
>>> > >>>> > Cleaning up the Bean creation
>>> > >>>> >
>>> > >>>> > In the past we had 2 ways to create beans. If an Extension used
>>> > >>>> > ProcessAnnotatedType to tweak the AnnotatedType of a class then
>>> we
>>> > >>>> built
>>> > >>>> > the *Bean<T>* from the modified *AnnotatedType<T>*. For cases
>>> where
>>> > >>>> the
>>> > >>>> > AnnotatedType did not get modified we took a completely
>>> different
>>> > >>>> part and
>>> > >>>> > created the Bean from the Class reflection information. This
>>> part
>>> > >>>> came from
>>> > >>>> > a time where there was no AnnotatedType in the spec yet.
>>> > >>>> >
>>> > >>>> > In OWB-1.2.0 we now do all the Bean<T> construction based on the
>>> > >>>> > AnnotatedType - regardless if it got provided by a
>>> CDI-Extension or
>>> > >>>> > remained unchanged. This made our codebase much easier to
>>> maintain!
>>> > >>>> Arne
>>> > >>>> > also did a great job by introducing and cleaning up all the
>>> > >>>> BeanBuilders
>>> > >>>> > and making the final Bean<T> immutable.
>>> > >>>> >
>>> > >>>> > (How) Should I modify this code, below, in my app to
>>> effectively use
>>> > >>>> OWB
>>> > >>>> > 1.2.0?
>>> > >>>> >
>>> > >>>> >     /*
>>> > >>>> >      *
>>> > >>>> >
>>> > >>>> >
>>> > >>>>
>>> >
>>> http://docs.oracle.com/javaee/6/api/javax/enterprise/inject/spi/BeanManager.html
>>> > >>>> >      *
>>> > >>>> >
>>> > http://struberg.wordpress.com/2012/03/20/why-is-openwebbeans-so-fast/
>>> > >>>> >      */
>>> > >>>> >     @SuppressWarnings("unchecked")
>>> > >>>> >     public <T> T getBean(Class<T> type) {
>>> > >>>> >         Bean<T> bean = (Bean<T>)
>>> > >>>> > beanManager.resolve(beanManager.getBeans(type));
>>> > >>>> >         CreationalContext<T>  creationalContext =
>>> > >>>> >
>>> > >>>> beanManager.createCreationalContext(bean);
>>> > >>>> >
>>> > >>>> >         return (T) beanManager.getReference(bean, type,
>>> > >>>> creationalContext);
>>> > >>>> >     }
>>> > >>>> >
>>> > >>>> >
>>> > >>>> >
>>> > >>>> >
>>> > >>>> > On Tue, Apr 30, 2013 at 8:44 AM, Howard W. Smith, Jr. <
>>> > >>>> > [email protected]> wrote:
>>> > >>>> >
>>> > >>>> > > LOL, interesting that you all mentioned OWB 1.1.7, but did not
>>> > >>>> mention
>>> > >>>> > OWB
>>> > >>>> > > 1.1.8. I know that TomEE has been using OWB 1.1.8 for some
>>> time
>>> > >>>> now. I
>>> > >>>> > > guess OWB 1.2 is somewhat-more-faster than OWB 1.1.8. :) This
>>> is
>>> > >>>> REALLY
>>> > >>>> > > peaking my interest! I love fast/performing app!
>>> > >>>> > >
>>> > >>>> > >
>>> > >>>> > > There is no bells and whistle and especially no reflection -
>>> just
>>> > >>>> pure
>>> > >>>> > > plain Java bytecode which is blazingly fast!
>>> > >>>> > >
>>> > >>>> > > Btw, we do very similar stuff for non-intercepted methods of
>>> > >>>> > > intercepted/decorated classes. And we also improved the
>>> handling
>>> > of
>>> > >>>> > > intercepted methods and are now more than twice as fast as
>>> > OWB-1.1.7
>>> > >>>> > (which
>>> > >>>> > > was already very fast).
>>> > >>>> > >
>>> > >>>> > >
>>> > >>>> > > On Tue, Apr 30, 2013 at 8:38 AM, Howard W. Smith, Jr. <
>>> > >>>> > > [email protected]> wrote:
>>> > >>>> > >
>>> > >>>> > >> Interesting, still reading...[1]
>>> > >>>> > >>
>>> > >>>> > >> As result of this unified handling we only stored the native
>>> > >>>> Contextual
>>> > >>>> > >> Instances in the Contexts (Session, Request map, Conversation
>>> > map,
>>> > >>>> etc).
>>> > >>>> > >> The negative side effect of this approach was that we had to
>>> > >>>> introduce a
>>> > >>>> > >> quite hacky mechanism to regain access to the
>>> CreationalContext.
>>> > >>>> > Needless
>>> > >>>> > >> to say that this was not only complex but also error prone.
>>> > >>>> > >>
>>> > >>>> > >> [1] http://blogs.apache.org/owb/
>>> > >>>> > >>
>>> > >>>> > >>
>>> > >>>> > >>
>>> > >>>> > >> On Tue, Apr 30, 2013 at 8:35 AM, Howard W. Smith, Jr. <
>>> > >>>> > >> [email protected]> wrote:
>>> > >>>> > >>
>>> > >>>> > >>> +1 cool!
>>> > >>>> > >>>
>>> > >>>> > >>> I'm about to download now/ASAP. I was about to ask you,
>>> what do
>>> > >>>> the
>>> > >>>> > test
>>> > >>>> > >>> results reveal of recently-added owb 1.2 to tomee 1.6.0
>>> > snapshot,
>>> > >>>> but
>>> > >>>> > >>> evidently, you knew where I was going.
>>> > >>>> > >>>
>>> > >>>> > >>>
>>> > >>>> > >>>
>>> > >>>> > >>>
>>> > >>>> > >>> On Tue, Apr 30, 2013 at 8:33 AM, Romain Manni-Bucau <
>>> > >>>> > >>> [email protected]> wrote:
>>> > >>>> > >>>
>>> > >>>> > >>>> cdi 1.0 tcks just passed this morning
>>> > >>>> > >>>>
>>> > >>>> > >>>> *Romain Manni-Bucau*
>>> > >>>> > >>>> *Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
>>> > >>>> > >>>> *Blog: **http://rmannibucau.wordpress.com/*<
>>> > >>>> > >>>> http://rmannibucau.wordpress.com/>
>>> > >>>> > >>>> *LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
>>> > >>>> > >>>> *Github: https://github.com/rmannibucau*
>>> > >>>> > >>>>
>>> > >>>> > >>>>
>>> > >>>> > >>>>
>>> > >>>> > >>>> 2013/4/30 Howard W. Smith, Jr. <[email protected]>
>>> > >>>> > >>>>
>>> > >>>> > >>>> > Are there many more tomee refactorings required, since
>>> owb
>>> > 1.2
>>> > >>>> is in
>>> > >>>> > >>>> the
>>> > >>>> > >>>> > house? :)
>>> > >>>> > >>>> >
>>> > >>>> > >>>> > I just thought about reading, News from
>>> OpenWebBeans-1.2.0
>>> > >>>> [1], and
>>> > >>>> > >>>> so far
>>> > >>>> > >>>> > it looks interesting.
>>> > >>>> > >>>> >
>>> > >>>> > >>>> > The Apache OpenWebBeans team has been quite busy with big
>>> > >>>> > >>>> refactorings. Big
>>> > >>>> > >>>> > improvements have been made to the proxying mechanism,
>>> the
>>> > Bean
>>> > >>>> > >>>> scanning
>>> > >>>> > >>>> > and the AnnotatedType handling. We managed to improve the
>>> > >>>> overall
>>> > >>>> > >>>> > performance again and now deliver almost native Java like
>>> > >>>> > performance
>>> > >>>> > >>>> for
>>> > >>>> > >>>> > our NormalScoping proxies.
>>> > >>>> > >>>> >
>>> > >>>> > >>>> > to read more, click URL below
>>> > >>>> > >>>> >
>>> > >>>> > >>>> > [1] http://blogs.apache.org/owb/
>>> > >>>> > >>>> >
>>> > >>>> > >>>> >
>>> > >>>> > >>>> > On Mon, Apr 29, 2013 at 9:35 AM, Romain Manni-Bucau
>>> > >>>> > >>>> > <[email protected]>wrote:
>>> > >>>> > >>>> >
>>> > >>>> > >>>> > > Hi,
>>> > >>>> > >>>> > >
>>> > >>>> > >>>> > > shouldn't change anything for you (that's the goal and
>>> > still
>>> > >>>> in
>>> > >>>> > >>>> progress)
>>> > >>>> > >>>> > >
>>> > >>>> > >>>> > > *Romain Manni-Bucau*
>>> > >>>> > >>>> > > *Twitter: @rmannibucau <
>>> https://twitter.com/rmannibucau>*
>>> > >>>> > >>>> > > *Blog: **http://rmannibucau.wordpress.com/*<
>>> > >>>> > >>>> > > http://rmannibucau.wordpress.com/>
>>> > >>>> > >>>> > > *LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
>>> > >>>> > >>>> > > *Github: https://github.com/rmannibucau*
>>> > >>>> > >>>> > >
>>> > >>>> > >>>> > >
>>> > >>>> > >>>> > >
>>> > >>>> > >>>> > > 2013/4/29 Howard W. Smith, Jr. <[email protected]
>>> >
>>> > >>>> > >>>> > >
>>> > >>>> > >>>> > > > Okay, owb 1.2 is in the house. Can you please clarify
>>> > what
>>> > >>>> is
>>> > >>>> > >>>> changing
>>> > >>>> > >>>> > > with
>>> > >>>> > >>>> > > > bean manager due to OpenWebBeans (owb) version 1.2
>>> and/or
>>> > >>>> > >>>> TOMEE-916[1]?
>>> > >>>> > >>>> > > Any
>>> > >>>> > >>>> > > > risks, pros, cons, performance enhancements, etc...?
>>> > >>>> > >>>> > > >
>>> > >>>> > >>>> > > > I am using bean manager instead of CODI bean manager.
>>> > that
>>> > >>>> is
>>> > >>>> > why
>>> > >>>> > >>>> I'm
>>> > >>>> > >>>> > > > asking. :)
>>> > >>>> > >>>> > > >
>>> > >>>> > >>>> > > > thanks,
>>> > >>>> > >>>> > > > Howard
>>> > >>>> > >>>> > > >
>>> > >>>> > >>>> > > > [1] https://issues.apache.org/jira/browse/TOMEE-916
>>> > >>>> > >>>> > > >
>>> > >>>> > >>>> > >
>>> > >>>> > >>>> >
>>> > >>>> > >>>>
>>> > >>>> > >>>
>>> > >>>> > >>>
>>> > >>>> > >>
>>> > >>>> > >
>>> > >>>> >
>>> > >>>>
>>> > >>>
>>> > >>>
>>> > >>
>>> > >
>>> >
>>>
>>
>>
>

Reply via email to