Hi, After the patch, JNDI dump in the example is not throwing the ClassCastException. May be I faced the issue since we are already have some other patches applied on top of the TomEE (Therefore this could be specific for my installation) I think since you have already tested the provide scenario and didn't face the issue it is ok to proceed with this release. Meanwhile I will give a try to isolate the issue cause without the patch and update the other mail thread.
Thanks a lot of the great support :) Cheers /Thusitha 2015-05-22 16:07 GMT+05:30 Romain Manni-Bucau <[email protected]>: > 2015-05-22 12:35 GMT+02:00 Jonathan Gallimore <[email protected]>: > >> You mean using http://localhost:8080/ejb-examples-1.1.1/jndi ? >> >> > was thinking to a manual call to JndiTreeBrowser but you are probably right > > >> That seems to be working here (for me at least) without issue with the >> out-of-the-box TomEE 1.7.2 Plus and the ejb-examples war (slightly >> modified >> as mentioned below - i.e. Transactional->Transaction and removing >> -SNAPSHOT >> from the path in context.xml). >> >> Shout if I'm missing anything. >> >> Jon >> >> On Fri, May 22, 2015 at 11:30 AM, Romain Manni-Bucau < >> [email protected]> >> wrote: >> >> > Side note: the issue appeared with the sample cause the jndi dumper was >> > called so all entries were created I think. What I'm not sure is why it >> > triggered it if it doesnt have any handler-chains. >> > >> > >> > Romain Manni-Bucau >> > @rmannibucau <https://twitter.com/rmannibucau> | Blog >> > <http://rmannibucau.wordpress.com> | Github < >> > https://github.com/rmannibucau> | >> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber >> > <http://www.tomitribe.com> >> > >> > 2015-05-22 12:27 GMT+02:00 Jonathan Gallimore <[email protected] >> >: >> > >> > > Hi >> > > >> > > Thanks for the feedback. >> > > >> > > I just grabbed a fresh copy of the release binary (from here: >> > > >> > > >> > >> https://repository.apache.org/content/repositories/orgapachetomee-1050/org/apache/openejb/apache-tomee/1.7.2/ >> > > ) >> > > and the examples ( >> > > >> > > >> > >> https://repository.apache.org/content/repositories/orgapachetomee-1050/org/apache/openejb/examples/4.7.2/ >> > > ) >> > > >> > > and build the ejb-examples and deployed. >> > > >> > > I ran into two issues - firstly META-INF/context.xml incorrectly >> > references >> > > a snapshot path for tomcat-users.xml, and secondly the WEB-INF/web.xml >> > > incorrectly references "Transactional" instead of "Transaction". We >> > should >> > > fix both of these (so thank you for pointing this out so we have found >> > > these issues) - but as they are an issue with the sample as opposed to >> > the >> > > server, I don't think either of these should block the release. >> > > >> > > Once I had corrected those, the sample deployed correctly and all the >> > flows >> > > worked for me. >> > > >> > > I think you have two issues we're actively discussing at the moment - >> one >> > > is the OpenJPA issues and the other is the Set vs List webservice >> issue >> > > which you sent a patch for - I'm wonder whether these are getting >> mixed >> > up >> > > here. I was specifically thinking of the Set vs List issue (that you >> > sent a >> > > patch for). >> > > >> > > My personal view on both of these: >> > > >> > > * The release is now at openjpa-2.4.0 so the nonfinal version should >> be >> > > used any more. You may also need to check that the javaagent is >> correctly >> > > setup. >> > > * The Set/List issue we'd run into under very specific conditions - >> > sounds >> > > like you have a service-ref and a custom handler chain if I've >> understood >> > > the explanation correctly. >> > > >> > > I'd suggest that we proceed with this release, as its now been open >> for >> > > nearly 5 days and looks good. A re-roll and re-vote will delay us by >> at >> > > least a week, and we have had two re-rolls already. I'm happy to >> > volunteer >> > > to do a 1.7.3 including your patch and any other necessary fixes in >> say, >> > a >> > > month's time? >> > > >> > > Regards >> > > >> > > Jon >> > > >> > > PS. Thanks for the patch and testing TomEE - we really appreciate it. >> > > >> > > On Fri, May 22, 2015 at 11:00 AM, Thusitha Thilina Dayaratne < >> > > [email protected]> wrote: >> > > >> > > > I was face the issue when running the JNDI dump in the provided >> tomee >> > > > ejb-example >> > > > >> > > > >> > > >> > >> http://svn.apache.org/repos/asf/tomee/tomee/branches/tomee-1.7.x/examples/ejb-examples/ >> > > > >> > > > I'm not really sure about whether it is a show-stopper for the >> relase. >> > > > >> > > > >> > > > Thanks >> > > > Best Regards >> > > > /Thusitha >> > > > >> > > > 2015-05-22 14:58 GMT+05:30 Jean-Louis Monteiro < >> > [email protected] >> > > >: >> > > > >> > > >> Not a regression. >> > > >> We can release later and keep going with this valid release. >> > > >> >> > > >> >> > > >> -- >> > > >> Jean-Louis Monteiro >> > > >> http://twitter.com/jlouismonteiro >> > > >> http://www.tomitribe.com >> > > >> >> > > >> On Fri, May 22, 2015 at 11:24 AM, Jonathan Gallimore < >> > > >> [email protected]> wrote: >> > > >> >> > > >>> Hi >> > > >>> >> > > >>> A patch has been pointed out on the user@ mailing list this >> morning: >> > > >>> >> > > >>> >> > > >> > >> http://tomee-openejb.979440.n4.nabble.com/Tomee-version-for-Tomcat-7-0-59-td4674740.html >> > > >>> , https://issues.apache.org/jira/browse/TOMEE-1590. >> > > >>> >> > > >>> >> > > >>> I'm not sure if its a show-stopper for the release, so we'll >> > continue, >> > > >>> but >> > > >>> please shout if you feel its a problem. Assuming we continue, I'm >> > happy >> > > >>> to >> > > >>> roll a 1.7.3 or 1.7.2.1 with some updates within the next couple >> of >> > > weeks >> > > >>> if that helps. >> > > >>> >> > > >>> Thusitha - please feel free to jump in (vote +1, 0 -1). I've seen >> the >> > > >>> patch, but a quick description of what I might need to do in an >> > > >>> application >> > > >>> to run into the issue might be help discussions here. >> > > >>> >> > > >>> Many thanks >> > > >>> >> > > >>> Jon >> > > >>> >> > > >>> On Wed, May 20, 2015 at 4:38 PM, Karan Malhi < >> [email protected]> >> > > >>> wrote: >> > > >>> >> > > >>> > +1 >> > > >>> > >> > > >>> > On Tue, May 19, 2015 at 9:41 AM, Josimar Alves < >> > > >>> [email protected]> >> > > >>> > wrote: >> > > >>> > >> > > >>> > > +1 >> > > >>> > > >> > > >>> > > >> > > >>> > > >> > > >>> > > >> > > >>> > > >> > > >>> > > *Josimar Silva* >> > > >>> > > Desenvolvedor Padawan >> > > >>> > > *josimaralves,[email protected] <[email protected]>* >> > > >>> > > <http://lattes.cnpq.br/8078900498490307> >> > > >>> > > <http://br.linkedin.com/pub/josimar-alves/41/388/870> >> > > >>> > > <https://github.com/DevPadawan> < >> https://twitter.com/DevPadawan >> > > >> > > >>> > > <https://plus.google.com/u/0/+JosimarAlves_DevPadawan/posts> >> > > >>> > > <http://www.oracle.com/technetwork/java/index.html> >> > > >>> > > <http://josimaralves.wordpresscom/> >> > > >>> > > <http://josimaralves.com/> >> > > >>> > > >> > > >>> > > On Tue, May 19, 2015 at 1:39 PM, David Blevins < >> > > >>> [email protected]> >> > > >>> > > wrote: >> > > >>> > > >> > > >>> > > > +1 >> > > >>> > > > >> > > >>> > > > >> > > >>> > > > -- >> > > >>> > > > David Blevins >> > > >>> > > > http://twitter.com/dblevins >> > > >>> > > > http://www.tomitribe.com >> > > >>> > > > >> > > >>> > > > On May 18, 2015, at 8:14 AM, Jonathan Gallimore < >> > > >>> > > [email protected]> >> > > >>> > > > wrote: >> > > >>> > > > >> > > >>> > > > > Hi >> > > >>> > > > > >> > > >>> > > > > I have re-rolled the latest 1.7.2 binaries, hopefully all >> is >> > > >>> well. >> > > >>> > > > > >> > > >>> > > > > GIT Tag: >> > > >>> > > > > >> > > >>> > > > >> > > >>> > > >> > > >>> > >> > > >>> >> > > >> > >> https://git-wip-us.apache.org/repos/asf?p=tomee.git;a=commit;h=57cb87f6fe45fb0f7fc43f557271da4ffee1cacf >> > > >>> > > > > >> > > >>> > > > > Maven Repo: >> > > >>> > > > > >> > > >>> > >> > > >> https://repository.apache.org/content/repositories/orgapachetomee-1050 >> > > >>> > > > > >> > > >>> > > > > Binaries & Source: >> > > >>> > > > > >> > > >>> > >> > > >> https://dist.apache.org/repos/dist/dev/tomee/staging-1050/tomee-1.7.2/ >> > > >>> > > > > >> > > >>> > > > > Legal: >> > > >>> > http://tomee.staging.apache.org/legal-tomee-1.7.2/archives.html >> > > >>> > > > > >> > > >>> > > > > Vote will be open for 72 hours or as needed. If you have >> any >> > > >>> concerns >> > > >>> > > or >> > > >>> > > > > queries, please shout. >> > > >>> > > > > >> > > >>> > > > > Many thanks >> > > >>> > > > > >> > > >>> > > > > Jon >> > > >>> > > > > >> > > >>> > > > > -- >> > > >>> > > > > Jonathan Gallimore >> > > >>> > > > > http://twitter.com/jongallimore >> > > >>> > > > > http://www.tomitribe.com >> > > >>> > > > >> > > >>> > > > >> > > >>> > > >> > > >>> > >> > > >>> > >> > > >>> > >> > > >>> > -- >> > > >>> > >> > > >>> > Karan Singh Malhi >> > > >>> > twitter.com/KaranSinghMalhi >> > > >>> > >> > > >>> >> > > >>> >> > > >>> >> > > >>> -- >> > > >>> Jonathan Gallimore >> > > >>> http://twitter.com/jongallimore >> > > >>> http://www.tomitribe.com >> > > >>> >> > > >> >> > > >> >> > > > >> > > > >> > > > -- >> > > > >> > > > >> > > >> > > >> > > >> > > -- >> > > Jonathan Gallimore >> > > http://twitter.com/jongallimore >> > > http://www.tomitribe.com >> > > >> > >> >> >> >> -- >> Jonathan Gallimore >> http://twitter.com/jongallimore >> http://www.tomitribe.com >> > > --
