Hi Romain,

I have noticed few things

1) org.apache.tomee.embedded.Main.java
Line 135 -  config.setDir(System.getProperty("java.io.tmpdir")); //Setting
to tmp dir
overridden in
Line 138 -  config.setDir(args.getOptionValue(DIRECTORY, new File(new
File("."), "apache-tomee").getAbsolutePath())); Setting to current
folder/apache-tomee

I think line 135 can be removed

2) In Container.java
 if (connector.getAttribute("connectionTimeout") == null) {
                connector.setAttribute("connectionTimeout", "3000");
            }
This condition never passes because connectionTimeout is never null default
value is 60000.
I don't know if this has any side effects because before this change we are
setting connect timeout to 3000 with out any condition.



--
View this message in context: 
http://tomee-openejb.979440.n4.nabble.com/Tomee-7-0-0M3-embedded-shade-fatjar-needs-improvements-tp4677935p4677942.html
Sent from the TomEE Users mailing list archive at Nabble.com.

Reply via email to