Hi guys,
Another issue that I've found:https://issues.apache.org/jira/browse/TOMEE-1827
When validating Resource Adapters connections with
ValidatingGenericConnectionManager, there is a case that just hands over the
pool object directly to the validate method, which may cause multiple Timer
threads to change the connections Set and cause a
java.util.ConcurrentModificationException.
This time, I've also submitted a patch :)
Cheers,Roberto
From: Roberto Cortez <[email protected]>
To: Romain Manni-Bucau <[email protected]>; "[email protected]"
<[email protected]>
Sent: Friday, May 20, 2016 9:43 AM
Subject: Re: Connector Resource Adapter Issues
Thank you Romain!
Next time, let me submit the patch myself :)
Cheers,Roberto
From: Romain Manni-Bucau <[email protected]>
To: "[email protected]" <[email protected]>; Roberto Cortez
<[email protected]>
Sent: Friday, May 20, 2016 12:01 AM
Subject: Re: Connector Resource Adapter Issues
Hi Roberto,
Made first one not failling as a tolerance (since properties are considered as
config properties you can then say you should just put a getter).
Second one was already fixed.
Romain Manni-Bucau
@rmannibucau | Blog | Github | LinkedIn | Tomitriber | JavaEE Factory
2016-05-20 2:14 GMT+02:00 Roberto Cortez <[email protected]>:
And the issues:
https://issues.apache.org/jira/browse/TOMEE-1816
https://issues.apache.org/jira/browse/TOMEE-1817
From: Roberto Cortez <[email protected]>
To: "[email protected]" <[email protected]>
Sent: Thursday, May 19, 2016 4:50 PM
Subject: Connector Resource Adapter Issues
Hi,
I have been implementing a Connector Resource Adapter and run into some issues:
- If I add a property getter into a resourceadapter-class or into a
managedconnectionfactory-class, when deploying I get a NPE, since it expects
the setter to be there. The deployed classes are available, but configuration
might not be loaded properly since the configuration load is interrupted by the
NPE. I had a look into the spec, and yes for config properties you are required
to have a getter / setter, but I couldn't find anything telling you that you
can't have a regular property with just a getter (it's just not configurable).
- When using the configuration "validationInterval" to provide connection
validation, the connector just fails to deploy with a
java.lang.NoSuchFieldException: pool
Did anyone else run into these issue?
In the meanwhile, I'm creating JIRA issue, plus tests. I would also like to fix
these myself if they confirm to be problems.
Cheers,Roberto
