Looks good to me (if anyone wants to apply it otherwise I'll do it end of the week)
Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le lun. 18 juin 2018 à 16:02, Gurkan Erdogdu <[email protected]> a écrit : > Also added test patch. > > On Mon, Jun 18, 2018 at 4:45 PM, Romain Manni-Bucau <[email protected] > > > wrote: > > > Misses a test (but looks good) and surely something to fix in > > https://github.com/apache/tomee/blob/master/tomee/tomee- > > embedded/src/test/java/org/apache/tomee/embedded/SslTomEETest.java > > since it should have tested it > > > > Romain Manni-Bucau > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > <https://rmannibucau.metawerx.net/> | Old Blog > > <http://rmannibucau.wordpress.com> | Github <https://github.com/ > > rmannibucau> | > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > <https://www.packtpub.com/application-development/java- > > ee-8-high-performance> > > > > > > Le lun. 18 juin 2018 à 15:39, Gurkan Erdogdu <[email protected]> a > > écrit : > > > > > Also added patch :) > > > > > > On Mon, Jun 18, 2018 at 4:37 PM, Gurkan Erdogdu <[email protected]> > > > wrote: > > > > > > > Hello > > > > I created the issue https://issues.apache.org/jira/browse/TOMEE-2196 > > > > Best > > > > Gurkan > > > > > > > > On Mon, Jun 18, 2018 at 4:29 PM, Romain Manni-Bucau < > > > [email protected] > > > > > wrote: > > > > > > > >> Hi Fabian, > > > >> > > > >> there is a bug for keystorefile, the property name is empty ( > > > >> https://github.com/apache/tomee/blob/fb_tomee8/tomee/tomee- > > > >> embedded/src/main/java/org/apache/tomee/embedded/ > > Container.java#L632), > > > >> feel free to submit a PR fixing that > > > >> > > > >> Romain Manni-Bucau > > > >> @rmannibucau <https://twitter.com/rmannibucau> | Blog > > > >> <https://rmannibucau.metawerx.net/> | Old Blog > > > >> <http://rmannibucau.wordpress.com> | Github < > > > >> https://github.com/rmannibucau> | > > > >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > > >> <https://www.packtpub.com/application-development/java-ee-8- > > > >> high-performance> > > > >> > > > >> > > > >> Le lun. 18 juin 2018 à 14:55, <[email protected]> > a > > > >> écrit : > > > >> > > > >> > Hi, > > > >> > > > > >> > > > > >> > > > > >> > I am migrating to TomEE 7.0.4 and our old TLS config in > > arquillian.xml > > > >> is > > > >> > not working any longer, the property > > > >> > > > > >> > > > > >> > > > > >> > property name="keystoreFile" > > > >> > > > > >> > > > > >> > > > > >> > seems to be ignored completely now, and ~/.keystore used instead. > > What > > > >> is > > > >> > the replacement? Where do I find documentation on arquillian.xml > > which > > > >> is > > > >> > up to date for the TomEE embedded driver? > > > >> > > > > >> > > > > >> > > > > >> > Thanks in advance and best > > > >> > > > > >> > Fabian > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > > > > > > > > > > >
