On Wed, Dec 4, 2013 at 11:29 AM, Igor Galić <[email protected]> wrote:
> > > ----- Original Message ----- > > On Dec 4, 2013, at 8:21 AM, Phil Sorber <[email protected]> wrote: > > > > > On Wed, Dec 4, 2013 at 9:13 AM, James Peach <[email protected]> wrote: > > > > > >> On Dec 3, 2013, at 10:09 PM, [email protected] wrote: > > >> > > >>> Updated Branches: > > >>> refs/heads/master 0022a5467 -> 52b6227cd > > >>> > > >>> > > >>> TS-1815: Add the file descriptor number to ET_AIO thread names > > >>> > > >>> > > >>> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo > > >>> Commit: > > >> http://git-wip-us.apache.org/repos/asf/trafficserver/commit/52b6227c > > >>> Tree: > http://git-wip-us.apache.org/repos/asf/trafficserver/tree/52b6227c > > >>> Diff: > http://git-wip-us.apache.org/repos/asf/trafficserver/diff/52b6227c > > >>> > > >>> Branch: refs/heads/master > > >>> Commit: 52b6227cd22f53a44ba38761d662dec9b22e6cfa > > >>> Parents: 0022a54 > > >>> Author: Phil Sorber <[email protected]> > > >>> Authored: Tue Dec 3 23:08:55 2013 -0700 > > >>> Committer: Phil Sorber <[email protected]> > > >>> Committed: Tue Dec 3 23:08:55 2013 -0700 > > >>> > > >>> > ---------------------------------------------------------------------- > > >>> CHANGES | 3 ++- > > >>> iocore/aio/AIO.cc | 2 +- > > >>> 2 files changed, 3 insertions(+), 2 deletions(-) > > >>> > ---------------------------------------------------------------------- > > >>> > > >>> > > >>> > > >> > http://git-wip-us.apache.org/repos/asf/trafficserver/blob/52b6227c/CHANGES > > >>> > ---------------------------------------------------------------------- > > >>> diff --git a/CHANGES b/CHANGES > > >>> index e8fdc32..52d15f9 100644 > > >>> --- a/CHANGES > > >>> +++ b/CHANGES > > >>> @@ -2,7 +2,8 @@ > > >>> Changes with Apache Traffic Server 4.2.0 > > >>> > > >>> > > >>> - *) [TS-1815] Add thread number and port to accept thread name > > >>> + *) [TS-1815] Add thread number and port to accept thread name and > > >>> + add the file descriptor number to the ET_AIO thread names > > >>> > > >>> *) [TS-2415] Use standard continuations to release UrlRewrite > objects. > > >>> > > >>> > > >>> > > >> > http://git-wip-us.apache.org/repos/asf/trafficserver/blob/52b6227c/iocore/aio/AIO.cc > > >>> > ---------------------------------------------------------------------- > > >>> diff --git a/iocore/aio/AIO.cc b/iocore/aio/AIO.cc > > >>> index 9f08e9e..a0fd386 100644 > > >>> --- a/iocore/aio/AIO.cc > > >>> +++ b/iocore/aio/AIO.cc > > >>> @@ -255,7 +255,7 @@ aio_init_fildes(int fildes, int fromAPI = 0) > > >>> thr_info = new AIOThreadInfo(request, 1); > > >>> else > > >>> thr_info = new AIOThreadInfo(request, 0); > > >>> - snprintf(thr_name, MAX_THREAD_NAME_LENGTH, "[ET_AIO %d]", i); > > >>> + snprintf(thr_name, MAX_THREAD_NAME_LENGTH, "[ET_AIO %d-%d]", > > >> fildes, i); > > >> > > >> Why is '-' the separator for AIO threads, but ':' the separator for > net > > >> threads? Also, this would be usefully documented in the man page ;) > > >> > > >> > > > I like : for ports. If it's not a port, : might be confusing. It's a > minor > > > change and I am not married to it. I think we just need *something* > there. > > > > I'd prefer ":" for both just to be consistent. > > Technically, this changes our API/ABI > > if someone out there has tools based on this, they will break. > Cross-posting this to users@. How strongly do you feel about this? Seems pretty tame to me, but if someone out there has a use case this breaks, I'm happy to revert on master and push out to 5.x. > > > > > Is there a particular man page you had in mind? I will update. > > > > Maybe the traffic_server man page? > > > > J > > > > ++ i > Igor Galić > > Tel: +43 (0) 664 886 22 883 > Mail: [email protected] > URL: http://brainsware.org/ > GPG: 8716 7A9F 989B ABD5 100F 4008 F266 55D6 2998 1641 > >
