The intent was that not all kind of components could be a button because of the single inheritance that java gives us But like Matej said, everywhere we do an instance check of button we should change that to do it on IFormSubmittingComponent
johan On 9/3/07, David Leangen <[EMAIL PROTECTED]> wrote: > > > Been trying to update to 1.3 and encountered some problems with > SubmitLink. > > Before, SubmitLink extended Button, so there were no problems with > forms. SubmitLinks could be used interchangeably with Buttons, and life > was good. > > Now, SubmitLink implements IFormSubmittingComponent, so it's breaking > some code. Implementing the interface seems reasonable to me, but the > code hasn't kept up with this change of mentality and there are some > inconsistencies. > > > In the wicket code, I tried changing > > Form.setDefaultButton(Button button) > > to > > Form.setDefaultButton(IFormSubmittingComponent button) > > > But this doesn't work, since some methods like onComponentTagBody are > programmed to the Button implementation rather than the > IFormSubmittingComponent interface. > > > It seems like a few things still need to be sorted out, or maybe the > SubmitLink should go back to extending button. > > > What's the story with this? What's the intent with the > ISubmittingComponent interface vs. Button vs. SubmitLink? > > I don't mind trying out some stuff, but please tell me the direction > that you're going with this. > > > Thanks! > David > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
