Done. Here is the issue link: 
https://issues.apache.org/jira/browse/WICKET-935 WICKET-935 


Matej Knopp-2 wrote:
> 
> Please do, so that we don't forget.
> 
> -Matej
> 
> On 9/6/07, Alex Objelean <[EMAIL PROTECTED]> wrote:
>>
>> Thank you again, Matej! :)
>> Will it be fixed, or should I create a task in JIRA?
>>
>> Alex
>>
>>
>> Matej Knopp-2 wrote:
>> >
>> > Some time ago onBeforeRender was called always, even if the component
>> > was not visible. This had caused problems with repeaters, therefore
>> > this restriction - to make sure onPopulate is called only when
>> > component is visible. But IMHO that's no longer necessary.
>> >
>> > -Matej
>> >
>> > On 9/6/07, Alex Objelean <[EMAIL PROTECTED]> wrote:
>> >>
>> >> I would prefer to use onBeforeRender, instead of onPopulate, since it
>> is
>> >> the
>> >> I do in other components. Why would I use different life-cycle
>> methods,
>> >> depending on the component I'm using?
>> >>
>> >> Alex
>> >>
>> >>
>> >> Matej Knopp-2 wrote:
>> >> >
>> >> > IMHO that's a bit wrong.
>> >> > You can subclass onPopulate instead, but i think we can remove the
>> >> > code, because after recent changes onBeforeRender() is only called
>> >> > when component is visible in hierarchy.
>> >> >
>> >> > -Matej
>> >> >
>> >> > On 9/6/07, Alex Objelean <[EMAIL PROTECTED]> wrote:
>> >> >>
>> >> >> I've grabbed the latest SNAPSHOT from the repository and have
>> noticed
>> >> >> that
>> >> >> AbstractRepeater#onBeforeRender is final. I wonder what is the
>> reason
>> >> for
>> >> >> this? (I need to do something in it's subclass)
>> >> >>         /**
>> >> >>          * @see org.apache.wicket.Component#onBeforeRender()
>> >> >>          */
>> >> >>         protected final void onBeforeRender()
>> >> >>         {
>> >> >>                 if (isVisibleInHierarchy())
>> >> >>                 {
>> >> >>                         onPopulate();
>> >> >>                 }
>> >> >>                 super.onBeforeRender();
>> >> >>         }
>> >> >>
>> >> >> Alex
>> >> >> --
>> >> >> View this message in context:
>> >> >>
>> >>
>> http://www.nabble.com/Why-the-AbstractRepeater-onBeforeRender-is-final-wicket-1.3.0-SNAPSHOT-%286-sept-2007%29--tf4391492.html#a12520558
>> >> >> Sent from the Wicket - User mailing list archive at Nabble.com.
>> >> >>
>> >> >>
>> >> >>
>> ---------------------------------------------------------------------
>> >> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> >> >> For additional commands, e-mail: [EMAIL PROTECTED]
>> >> >>
>> >> >>
>> >> >
>> >> >
>> ---------------------------------------------------------------------
>> >> > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> >> > For additional commands, e-mail: [EMAIL PROTECTED]
>> >> >
>> >> >
>> >> >
>> >>
>> >> --
>> >> View this message in context:
>> >>
>> http://www.nabble.com/Why-the-AbstractRepeater-onBeforeRender-is-final-wicket-1.3.0-SNAPSHOT-%286-sept-2007%29--tf4391492.html#a12520766
>> >> Sent from the Wicket - User mailing list archive at Nabble.com.
>> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> >> For additional commands, e-mail: [EMAIL PROTECTED]
>> >>
>> >>
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > For additional commands, e-mail: [EMAIL PROTECTED]
>> >
>> >
>> >
>>
>> --
>> View this message in context:
>> http://www.nabble.com/Why-the-AbstractRepeater-onBeforeRender-is-final-wicket-1.3.0-SNAPSHOT-%286-sept-2007%29--tf4391492.html#a12521043
>> Sent from the Wicket - User mailing list archive at Nabble.com.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 
> 

-- 
View this message in context: 
http://www.nabble.com/Why-the-AbstractRepeater-onBeforeRender-is-final-wicket-1.3.0-SNAPSHOT-%286-sept-2007%29--tf4391492.html#a12521149
Sent from the Wicket - User mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to