Hi,

According to the javadoc Form.updateFormComponentModels should update all the models of all FormComponents in a form (without validation presumably?). This sets all the model objects to the convertedInput value (in FormComponent.updateModel), unfortunately convertedInput is only set after a call to validate(). This really makes updateFormComponentModels useless as a protected method. If validation is really mandatory (which I doubt), processInput should be the only callable method as it validates first and then updates the model.

In any case, the call to convertInput() inside validate() strikes me as odd (the wrong place to call such a method). Also, the javadoc of FormComponent.updateModel() states: ".. it expect that the object is already converted through the convert() call", but there is no convert() method in FormComponent.

Off-topic: Why are so much methods marked final? This might prevent API-misuse but also prevents innovative _use_! I can understand you want framework users to do it the wicket way, because they will probably only spam the users list with questions that have obvious solutions (like me :D ). But sometimes it's just frustrating. Maybe this is a consequence of the fact that wicket forces you to subclass components so much. It's just too tempting to override so much methods. I love wicket (I really do!) but I'd rather see wicket more event listener oriented. This would also make it easier to listen to events that are very deeply nested (fetch the component, register a listener), which is almost impossible now.

--
Matthijs Wensveen
Func. Internet Integration
W http://www.func.nl
T +31 20 4230000
F +31 20 4223500


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to