Hi,

  I'm not 100% sure, but after a quick look, I'd say that it's possible that
  the following fix changed the test return.  Cross-posted to dev@ to see if
  anyone's got any comments...

Revision: 575980
Author: ivaynberg
Date: 15/09/2007 22:09:08
Message:
WICKET-974: Image#getResource always returns null even if there is a resource 
http://issues.apache.org/jira/browse/WICKET-974
----
Modified : 
/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/Image.java
Modified : 
/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java

/Gwyn
  

On Friday, September 21, 2007, 10:29:57 PM, Martin <[EMAIL PROTECTED]> wrote:

> Hi,

> am I the only one catching this on a mvn clean install?

> [...]
> [surefire] Running org.apache.wicket.markup.html.image.ImageTest
> [surefire] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0,055 sec
> <<<<<<<< FAILURE !!
> [...]

> According to svn the ImageTest.java wasn't touched for over three month

> svn info 
> ./jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/image/ImageTest.java
> [...]
> Letzte geänderte Rev: 543933
> Letztes Änderungsdatum: 2007-06-03 18:18:27 +0200 (So, 03 Jun 2007)
> [...]

> and I've definitely seen it running in that timespan.

> Following patch would fix the test, but fixing that doesn't feel right.

> Somehow I don't get it.

> Martin

> Index: 
> ./jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/image/ImageTest.java
> ===================================================================
> --- 
> /home/fnk64/tmp/wicket-1.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/image/ImageTest.java
> (Revision 578270)
> +++ 
> /home/fnk64/tmp/wicket-1.x/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/image/ImageTest.java
> (Arbeitskopie)
> @@ -62,6 +62,6 @@
>         
>          tester.clickLink("goUS");
>          tester.startPage(Home.class);
> -        
> tester.assertContains("src=\"resources/org.apache.wicket.markup.html.image.Home/Beer_en_US.gif\"");
> +        
> tester.assertContains("src=\"resources/org.apache.wicket.markup.html.image.Home/Beer.gif\"");
>      }
>  }



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to