I have no problem with the approach in finals. I think you guys have done a great job.
Please see my response http://www.nabble.com/Redirect-to-HTTPS--tf4509537.html#a12878724 here I, too, am very interested in the feedback on this. Eelco Hillenius wrote: > >> I haven't tested but I think the solution is to override public final >> CharSequence encode(final RequestCycle requestCycle, final >> IRequestTarget >> requestTarget)....BUT...it is final so we can't reuse the class directly >> but >> have to make a copy. > > And this is where your alarm bells should go off. Admittedly we have > been very generous in using final, maybe sometimes a bit too much, but > the idea behind it is that we think that what you want to do can > probably be done in a better way, or we simply don't know (and an > unrelated reason is self protection so that we have more options for > refactoring without breaking the whole world). So, any time you come > across a situation where something is final and you think you have a > really good use case to get rid of it, you should post a message here. > Chances are we can tell you a better way to do it, or you convince us > to remove final or in some other way facilitate your use case. > > As for your case, I'd like to hear what Al thinks about this. It might > work to make the factor prepending into a separate, overridable > method. > > Eelco > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > -- View this message in context: http://www.nabble.com/Redirect-to-HTTPS--tf4509537.html#a12878787 Sent from the Wicket - User mailing list archive at Nabble.com. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
