I didn't want to sound to harsh, but I do think that opening up such a basic, core feature to overriding is something not taken lightly. There is a whole world of beginning Wicket users that need protection from abusing the API.
Opening up this for your specific usecase would open up a whole can of worms: not only add, but also replace, replaceWith, etc need to be monitored. If we are going to support your usecase, I'd rather do it in a way that is sustainable, and not by just randomly removing final keywords. Martijn On 9/29/07, Sam Hough <[EMAIL PROTECTED]> wrote: > > I've put at the start of most questions that I've not got my head around > Wicket yet and so it is probably me not seeing the obvious Wicket way to do > something. > > I'm sorry if I've gone on about this too much but I thought I had > encouragement to raise this as a JIRA issue so at least I could be told no > for good. > > I probably won't be a long term supporter of Wicket but I've honestly tried > to help out as much as I can while I'm here. > > Thanks for all your efforts. > > Bye. > > > > Martijn Dashorst wrote: > > > > I am getting more convinced that you are trying to shoehorn wicket in > > a way it is not intended. Wicket is not GWT. Repeat after me: Wicket > > is not GWT. > > > > Yes I trust *you* will will not f*ck up overriding the methods. But > > there are about a thousand other developers for you that are more > > likely to do awful things if we open up our api for your usecase. > > > > Wicket is open source, so you have the ability to remove the final > > clauses in your own version. It is not *that* hard to remove them > > yourself and keep up with our releases. > > > > I'd rather not accomodate you and leave you to your true love than > > open up our api so that we can receive hell if we change something > > internally, or have constant issues on the user list that something > > doesn't work because someone forget to call super. Are *you* going to > > provide the support on this list for all those cases? Helping out > > those that are a bad boy and don't write unit tests? And how about in > > a year when you are on your next project? Will you still help out on > > the lists? > > > > Martijn > > > > On 9/29/07, Sam Hough <[EMAIL PROTECTED]> wrote: > >> > >> Errr. Should I take from all this not to use the page versioning and that > >> I > >> shouldn't hold my breath for final being removed from anywhere? > >> > >> I know you are all sick of this topic, poor old Eelco, but seems like a > >> simple, efficient and flexible way for me to add hooks is to extend > >> objects. > >> If you mark methods as "extend at own risk" and I go down a stupid route > >> that is my own stupidity. At least I can get something reasonable working > >> in > >> the short term even if it can be done better later. I'm a good boy so I > >> have > >> lots of unit and functional tests to catch mistakes later. > >> > >> Sorry that I'm struggling with the wicket way. To add to my confusion I'd > >> rather onClick, onSubmit etc were interfaces so I could choose if I > >> wanted > >> them in the component (to reduce numbers of objects) or anywhere I like. > >> > >> > >> Matej Knopp-2 wrote: > >> > > >> > On 9/27/07, Johan Compagner <[EMAIL PROTECTED]> wrote: > >> >> the problem is that that still not really does auto dirty.. > >> >> Because where does it end? just add/remove/visitble/enable? > >> >> The nice thing is we have already something like that: thats page > >> >> versioning > >> >> with the undo/change map. > >> > Don't get too attached to it :) We should remove it in the next > >> > version, doesn't make much sense for 2nd level cache session store :) > >> > > >> > -Matej > >> > > >> >> If we extend that a little bit then we could have something like > >> >> componentChanged(component) on a page (or somekind of listener) > >> >> and that component did trigger it self what ever did happen on it > >> >> (getting a > >> >> child, settting the visibility, or setting an internal none wicket > >> core > >> >> property) > >> >> > >> >> johan > >> >> > >> >> > >> >> > >> >> On 9/26/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > >> >> > > >> >> > On 9/26/07, Johan Compagner <[EMAIL PROTECTED]> wrote: > >> >> > > but this discussion is not just about getter/setters (i don't care > >> >> about > >> >> > > those) > >> >> > > but also for add and remove.. then we are getting into some other > >> >> stuff > >> >> > > >> >> > Yes. Getters/ setters are less tricky. Though I'm still not breaking > >> >> > in sweat when I imagine removing final on add and remove. > >> >> > > >> >> > Eelco > >> >> > > >> >> > > >> --------------------------------------------------------------------- > >> >> > To unsubscribe, e-mail: [EMAIL PROTECTED] > >> >> > For additional commands, e-mail: [EMAIL PROTECTED] > >> >> > > >> >> > > >> >> > >> > > >> > --------------------------------------------------------------------- > >> > To unsubscribe, e-mail: [EMAIL PROTECTED] > >> > For additional commands, e-mail: [EMAIL PROTECTED] > >> > > >> > > >> > > >> > >> -- > >> View this message in context: > >> http://www.nabble.com/auto-dirty-and-widget-factory-tf4421187.html#a12954673 > >> Sent from the Wicket - User mailing list archive at Nabble.com. > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [EMAIL PROTECTED] > >> For additional commands, e-mail: [EMAIL PROTECTED] > >> > >> > > > > > > -- > > Buy Wicket in Action: http://manning.com/dashorst > > Apache Wicket 1.3.0-beta3 is released > > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta3/ > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > -- > View this message in context: > http://www.nabble.com/auto-dirty-and-widget-factory-tf4421187.html#a12955683 > Sent from the Wicket - User mailing list archive at Nabble.com. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- Buy Wicket in Action: http://manning.com/dashorst Apache Wicket 1.3.0-beta3 is released Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta3/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
