Which is the name of the embebed Eclipse browser you are using?
On Mon, Mar 17, 2008 at 7:15 PM, Igor Vaynberg <[EMAIL PROTECTED]>
wrote:
> there are a couple of things i would change
>
> 1) add(new StyleSheetReference("pageCss", getClass(), "flickr.css"));
>
> do you really need that? can you not simply put link tag inside
> wicket:link tags?
>
> 2) // Initially there is no photo to display so add a temporary place
> holder component to make Wicket happy
>
> you dont need to do that, make loadable detachable model that is
> pulling image links return an empty list if tags string is empty, that
> way you add the listview right away and dont need that replace mambo
> jumbo
>
> 3) Photo photo = (Photo) item.getModelObject(); item.add(new
> Thumbnail("t", photo));
>
> im not a big fan of that, why not simply item.add(new Thumbnail("t",
> item.getModel()));
>
> it makes code simpler, you dont load the model object needlessly, and
> it makes thumbnail more flexible by taking an imodel.
>
> 4) img.add(new SimpleAttributeModifier("src", photo.getSmallSquareUrl()));
>
> you can just create an anon subclass of src wmc and subclass
> oncomponenttag() directly and save some space.
>
> pretty sweet tutorial though, thanks
>
> -igor
>
>
> On Mon, Mar 17, 2008 at 1:04 PM, Matthew Young <[EMAIL PROTECTED]> wrote:
> > Hi, I am new to Wicket and to help me learn, I created a Wicket version
> of
> > the Flickr demo like the one on the Ruby on Rails site seen here
> > http://www.rubyonrails.org/screencasts. I put my version in my blog
> here:
> > http://limboville.blogspot.com/2008_03_01_archive.html. Please take a
> look
> > and give me some feedback.
> >
> > Thanks!
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
--
Fernando Wermus.
