its not the listitem itself but any direct child of the repeater, that
is why i factored out an AbstractRepeater class that all other
repeaters extend.
-igor
On Tue, May 27, 2008 at 4:14 AM, Johan Compagner <[EMAIL PROTECTED]> wrote:
> I already fixed the page issue
> But you are right about the repeaters that still can generate multiply per
> key
> I guess ListItem should be jumped over in that generation
>
> Can you make a jira issue?
>
> johan
>
>
> On Tue, May 27, 2008 at 12:42 PM, badaud <[EMAIL PROTECTED]> wrote:
>
>>
>> I think I noticed a bigger issue in the generation of cache keys: they seem
>> to be always unique, as they use the id of components:
>> Component< ? > cursor = component;
>> while (cursor != null)
>> {
>>
>> buffer.append("-").append(cursor.getClass().getName());
>> buffer.append(":").append(cursor.getId());
>> cursor = cursor.getParent();
>> }
>>
>> But this is an issue, as each time a page is generated, it has a different
>> id (and the same kind of stuff happens in repeaters).
>>
>> As I just mentioned on the ##wicket IRC channel:
>> [12:12] <Badaud> Helloo, helloo
>> [12:13] <Badaud> I have question regarding the wicket localizer which seems
>> to be related to, I think, a bug (or an erroneous behaviour) in the
>> getCacheKey() method
>> [12:13] <Badaud> I just noticed that the cache variable is always
>> increasing
>> in size in the localizer
>> [12:15] <Badaud> even when I just do a simple refresh of a page
>> [12:16] <Badaud> This seems to be linked to the fact that the getCacheKey
>> add the ID of components in the component tree
>> [12:16] <Badaud> when building the key
>> [12:16] <Badaud> but the id for pages change all the time
>> [12:16] <Badaud> which means that every time a new page is loaded
>> [12:17] <Badaud> sorry
>> [12:17] <Badaud> every time the same page is loaded
>> [12:17] <Badaud> a new set of ids is generated
>> [12:17] <Badaud> this looks like a memory leak to me
>> [12:19] <Badaud> I think that the id of the component shouldn't be part of
>> the path (or it shouldn't be used when the component cursor is on a page...
>> but wouldn't this be the case also in List views?)
>> [12:21] <Badaud> I mean, in repeaters?
>> [12:24] <Badaud> Like this:
>> [12:24] <Badaud>
>>
>> label.allStates-org.apache.wicket.markup.html.basic.Label:state-org.apache.wicket.markup.repeater.Item:14-...........-com.mycompany.SomePage:18-en-null
>>
>> --
>> View this message in context:
>> http://www.nabble.com/Why-Localizer-Retained-so-many-heapsize--tp17142582p17487594.html
>> Sent from the Wicket - User mailing list archive at Nabble.com.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
