Hi Ryan
So, now I have merged our two versions, I had to add the two new
interface methods as NOOP's on multiple effect. I use the setQueue to
obtain the same as the new multiple effect btw. Funny how many ways
there are todo stuff:)
I guess I should add blind up and blind down effects too?
Nino Saturnino Martinez Vazquez Wael wrote:
Ryan Sonnek wrote:
Nino,
you overwrote my changes to the Effect class. Please revert your
changes
and restore my Effect.multiple addition.
I'll do that ASAP, will probably first be tommorrow.
I can't find *any* reference to this "toaster" in the core scriptaculous
library.
It's a combination of effects(the example effects from scriptaculous),
something that fades in shakes and for example squishes.. Did you see
the example?
please provide a url. is this a custom effect? If so, i think it
should be moved out of the scriptaculous project and into a separate
wicketstuff project.
Reason being, keeping the core scriptaculous library
uncluttered allows for a quicker upgrade cycle since we don't need to
track
down and test every user contributed component.
On Mon, Jun 9, 2008 at 3:08 AM, Nino Saturnino Martinez Vazquez Wael <
[EMAIL PROTECTED]> wrote:
Sorry, something were messed up with my svn, so I think I might have
overriden what you just commited(it stated that you just deleted
files). But
take a look at it and see if it's okay.. It turned out that I only
need to
add an option to set queue on effects... However I also added the
parallel
effect, but we could remove it since i do not use it.
You can see in the scriptacoulus how the toaster works...
Ryan Sonnek wrote:
Okay Nino, I've created a new Effect.multiple that should give you
what
you
need. take a look and let me know what you think. here's how it
works:
AbstractEffect[] effects = new AbstractEffect[] {
new Effect.Fade(component1),
new Effect.Highlight(component2),
etc...
}
new Effect.multiple(effects).toJavascript();
On Fri, Jun 6, 2008 at 9:41 PM, Ryan Sonnek <[EMAIL PROTECTED]>
wrote:
I'll take a swing at it and try to check something workable in asap.
On 6/6/08, Nino Saturnino Martinez Vazquez Wael
<[EMAIL PROTECTED]
wrote:
Hmm
The Effect's as they are now gives me some trouble, because you
need to
give the component when creating the component. It would be much
more
flexible if it could be changed. And would allow the user to control
which
effects were used..
So what do you say? I could make the change:) API should be okay,
and we
could deprecate the old constructor..
Ryan Sonnek wrote:
Not sure what this 'toaster' is, but i really like the multiple
effect!
is
it available in 1.8 or is this in scriptaculous 2.0?
We have a scriptaculous header contributor using the
ScriptaculousAjaxBehavior.newJavascriptBindingBehavior(). do
you need
something different?
On Wed, Jun 4, 2008 at 8:32 PM, Nino Saturnino Martinez Vazquez
Wael <
[EMAIL PROTECTED]> wrote:
Hi Ryan?
I need this effect :
http://github.com/madrobby/scriptaculous/wikis/effect-multiple
to be
able
to build the toaster. It's almost done, a scriptaculous header
contributor
would also be very nice.
When im done with the toaster should I just add it to the project?
--
-Wicket for love
Nino Martinez Wael
Java Specialist @ Jayway DK
http://www.jayway.dk
+45 2936 7684
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
-Wicket for love
Nino Martinez Wael
Java Specialist @ Jayway DK
http://www.jayway.dk
+45 2936 7684
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
-Wicket for love
Nino Martinez Wael
Java Specialist @ Jayway DK
http://www.jayway.dk
+45 2936 7684
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
-Wicket for love
Nino Martinez Wael
Java Specialist @ Jayway DK
http://www.jayway.dk
+45 2936 7684
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
