Thanks!
Regards,
Matthew.
On Mon, Jul 14, 2008 at 12:56 PM, Matej Knopp <[EMAIL PROTECTED]> wrote:
> Looks like M3 should be fine.
>
> -Matej
>
> On Mon, Jul 14, 2008 at 7:51 PM, Matej Knopp <[EMAIL PROTECTED]>
> wrote:
> > I'm sorry about this. It should be fixed in trunk.
> > Did the broken revision made it to 1.4m3?
> >
> > -Matej
> >
> > On Mon, Jul 14, 2008 at 7:31 PM, Matthew Hanlon <[EMAIL PROTECTED]>
> wrote:
> >> I just updated my 1.4 SNAPSHOT to revision 676639 and I've started
> noticing
> >> an error in ModalWindow when using ModalWindow.PageCreator. It looks
> like
> >> the setPageCreator method is calling setContent(empty) after setting the
> >> page creator, which in turn sets the page creator to null.
> >>
> >> From ModalWindow.java rev 676639:
> >> public void setPageCreator(PageCreator creator)
> >> {
> >> pageCreator = creator;
> >> setContent(empty);
> >> }
> >>
> >> ...
> >>
> >> public void setContent(Component component)
> >> {
> >> if (component.getId().equals(getContentId()) == false)
> >> {
> >> throw new WicketRuntimeException("Modal window content id is
> >> wrong.");
> >> }
> >> component.setOutputMarkupPlaceholderTag(true);
> >> component.setVisible(false);
> >> replace(component);
> >> shown = false;
> >> pageCreator = null;
> >> }
> >>
> >> I have an older revision (667319) that does not have this problem;
> first,
> >> setPageCreator does not call setContent(empty), and also setContent does
> not
> >> set pageCreator = null. Removing this line from setContent fixes the
> >> problem, however I don't know what other repercussions it may have.
> >>
> >> Regards,
> >> Matthew.
> >>
> >> --
> >> Matthew Rollins Hanlon
> >> http://squareoftwo.org
> >> _____________________
> >> Hanlon's Razor:
> >> "Never attribute to malice that which can be adequately explained by
> >> stupidity."
> >> http://wikipedia.org/wiki/Hanlon's_razor<http://wikipedia.org/wiki/Hanlon%27s_razor>
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
--
Matthew Rollins Hanlon
http://squareoftwo.org
_____________________
Hanlon's Razor:
"Never attribute to malice that which can be adequately explained by
stupidity."
http://wikipedia.org/wiki/Hanlon's_razor
