if you guys want to test if wicket still leaks a threadlocal somehow
then what you should do is make a filter that goes around our filter
and that test the Session.get(),  RequestCycle.get() and the
Applicaiton.get()
if one of these are already there before (and after) our wicketfilter then
there is a leak

And that is what was fixed, somehow there could be an request dont remember
exactly which one
that could throw an exception again in a finally block and because of that
the finally block that did its job wasnt executed completely

johan


On Thu, Sep 11, 2008 at 4:37 PM, Weaver, Scott <[EMAIL PROTECTED]>wrote:

> Thanks Martijn.  The comments/description really doesn't tell me much, I
> will see if looking at the code changes tells me more.
>
> Thanks again,
> -scott> -----Original Message-----> From: Martijn Dashorst [mailto:
> [EMAIL PROTECTED]> Sent: Thursday, September 11, 2008 9:22 AM>
> To: [EMAIL PROTECTED] <[email protected]>
> > Subject: Re: cross session leakage
> >
> > afaik http://issues.apache.org/jira/browse/WICKET-1409
> >
> > On Thu, Sep 11, 2008 at 3:35 PM, Weaver, Scott
> > <[EMAIL PROTECTED]> wrote:
> > > Yes I to would like to know the cause also as we have had this happen
> > more than once in our production environment, five or six times that I
> > know (through trouble tickets).
> > >
> > > -scott
> > >
> > >> -----Original Message-----
> > >> From: Edward [mailto:[EMAIL PROTECTED]
> > >> Sent: Wednesday, September 10, 2008 4:44 PM
> > >> To: [email protected]
> > >> Subject: cross session leakage
> > >>
> > >>
> > >> 1.3.4 says it fixed cross session leakage due to a dangling thread
> > >> local
> > >> in exceptional circumstances... but I don't see an actual but
> > >> identified
> > >> in the release notes.  What exactly was fixed and what was the
> > >> exceptional circumstance?
> > >>
> > >> Thanks,
> > >>
> > >> Edward
> > >>
> > >>
> > >>
> > >> --------------------------------------------------------------------
> > -
> > >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> > >> For additional commands, e-mail: [EMAIL PROTECTED]
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > For additional commands, e-mail: [EMAIL PROTECTED]
> > >
> > >
> >
> >
> >
> > --
> > Become a Wicket expert, learn from the best: http://wicketinaction.com
> > Apache Wicket 1.3.4 is released
> > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

Reply via email to