On Mon, 06 Oct 2008, rmorrisey wrote: > wicket 1.3.4 > I have a small addition to ModalWindow that I think would be useful as a > patch. Please tell me what you think.
Hi, it sounds like a nice idea, though I don't know what exactly what it could be used for :) Displaying some notification after closing the window? > http://www.nabble.com/file/p19849489/ModalWindow.java ModalWindow.java However, the contribution is better done as a patch against Wicket trunk (and/or 1.3.x at the moment) attached to a Jira issue. That way, it's also a lot easier to review your changes -- and those familiar with ModalWindow can comment on whether the addition is worthwhile or if there is already a way to achieve the same. Best wishes, Timo -- Timo Rantalaiho Reaktor Innovations Oy <URL: http://www.ri.fi/ > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
