already on the roadmap/wishlist for 1.5 :)
-igor
On Sun, Nov 23, 2008 at 2:21 PM, Johan Compagner <[EMAIL PROTECTED]> wrote:
> We really should straighten this isVisible up.
> Make it final, and let that on check flag and the other isVisible
> things with an overridable method that users can override. (and maybe
> cache this result in a flag for 1 request)
>
> On 11/23/08, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
>> sounds like a bug. open a jira issue.
>>
>> -igor
>>
>> On Sun, Nov 23, 2008 at 2:06 PM, dukehoops <[EMAIL PROTECTED]> wrote:
>>>
>>> I have a component whose parent does this:
>>>
>>> class Parent extends Panel
>>>
>>> private Component child;
>>>
>>> onBeforeRender()
>>> {
>>> child.setVisibilityAllowed(false);
>>> super.onBeforeRender();
>>> }
>>>
>>> I would expect child's onBeforeRender() to not be executed but it is,
>>> because Component.internalBeforeRender calls isVisible() rather than
>>> determineVisibility().
>>>
>>> Is that by design? If so, why?
>>>
>>> If this is a bug, should the following line in
>>> Component.internalBeforeRender():
>>>
>>> if ((isVisible() || callOnBeforeRenderIfNotVisible()) &&
>>> !getFlag(FLAG_RENDERING) &&
>>> !getFlag(FLAG_PREPARED_FOR_RENDER))
>>>
>>> be this:
>>>
>>> if ((determineVisibility() ||
>>> callOnBeforeRenderIfNotVisible()) &&
>>> !getFlag(FLAG_RENDERING) &&
>>> !getFlag(FLAG_PREPARED_FOR_RENDER))
>>>
>>> thanks
>>> -nikita
>>>
>>>
>>>
>>>
>>> -----
>>> ----------------
>>> Nikita Tovstoles
>>> vside.com
>>> ----------------
>>>
>>> --
>>> View this message in context:
>>> http://www.nabble.com/isVisibilityAllowed%28%29-not-consulted-before-calling-onBeforeRender%28%29--tp20651326p20651326.html
>>> Sent from the Wicket - User mailing list archive at Nabble.com.
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
