im not sure how necessary the threadlocal is. yes, it took up 6mb of memory, but those instances are not being held on to, so if you run GC all that memory will be reclaimed.
-igor On Sun, Feb 8, 2009 at 8:55 PM, Martin Makundi <[email protected]> wrote: > Cool. What is your take on using a ThreaLocal instead of always > cloning return (NumberFormat)numberFormat.clone(); in > org.apache.wicket.util.convert.converters.AbstractDecimalConverter#getNumberFormat(java.util.Locale) > > ** > Martin > > 2009/2/9 Igor Vaynberg <[email protected]>: >> On Sun, Feb 8, 2009 at 7:46 PM, Martin Makundi >> <[email protected]> wrote: >>> Another thing that came into my mind is, that there is >>> newNumberFormat(Locale locale) -method in AbstractDecimalConverter, >>> but the method is never used [instead, there is a direct "numberFormat >>> = NumberFormat.getInstance(locale);" -invocation in >>> getNumberFormat(Locale locale)]. >> >> fixed >> >> -igor >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
