Hi,
This concerns Wicket Version : 1.4-rc2
In componentModelChange class, we see the following :
@Override
public String toString()
{
return "ComponentModelChange[component: " + getPath() + "]";
}
"ComponentModelChange[" piece of it, in toString( ) shouldn't that be
this.getClass().getSimpleName( ) + "[" or something in those lines, I see
that most of the component change classes are based on a format like that
... am i missing something? If we see the Behaviour Change code that follows
, we use more dynamic this.getClass() to spit out toString( ); If I may ask,
is the Behavior change toString ( ) and OtherChange format different by some
agreeable convention ? Also the toString( ) seems to be missing on
ComponentBorderChange class.
One more small observation, our naming conventions on Change class are
inconsistent in many cases, for example, VisibilityChange and EnabledChange
.. for what? question comes to mind, and the answer is component ... that to
me infers that either it should be:
1.) Change<COMPONENT extends Component>
if above is not acceptable, then
2.) name it like ComponentEnabledChange or something in those lines?
Just some thoughts.
Sorry If questions have already been answered or are not appropriate,
thought i'd ask the programming elites of wicket ;)
Regards
Vyas, Anirudh
|| ॐ ||
