I am using GAE + Wicket too, and I also had to copy/paste that class.
Any chances of making a refactor in a future release?
Thanks a lot! :)
Nico
Esteban Masoero-2 wrote:
>
> Hi there:
>
> In MultipartServletWebRequest constructor we have:
> ...
> (line 93) DiskFileItemFactory factory = new DiskFileItemFactory();
> ...
> which inhibits anyone from reusing MultipartServletWebRequest with a
> different factory. The only solution is generate a new class that is a
> copy of this one, with that line changed.
>
> Would it be possible to extract this code in a method like:
>
> /** Creates and returns a new file item factory. Subclasses can
> override this method to use a different factory
> * @returns a recently created FileItemFactory object
> */
> protected FileItemFactory getNewFileItemFactory() {
> return new DiskFileItemFactory();
> }
>
> This way, we could just extend this class when there's a need to use a
> different factory (as in GAE applications)
>
> Thanks in advance,
>
> Esteban
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>
>
--
View this message in context:
http://www.nabble.com/Extract-method-suggestion-in-MultipartServletWebRequest-class-tp25390796p25456459.html
Sent from the Wicket - User mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
