Hi Wicketeers,

I just noticed that this constructor
public ExternalLink(final String id, final IModel<String> href, final *IModel<String>* label)
takes  IModel<String> for label.
This is somewhat limiting since the model could hold a number or a date for example.
Actually passing a raw IModel with any object inside works just fine.

It would be more appropriate if this constructor takes IModel<?> for the label as done in Label constructor. Unfortunately ExternalLink offers a public method getLabel() that returns the label as IModel<String>.
So it seems changing it would break compatibility.

Using wicket 1.4.1.

Best regards,
Peter

Reply via email to