Hi Rodolfo,

I think you would need two wicketstuff-push parents (one for java5 and one for java6) each with a separate artifactid.

Like:

wicketstuff-core -> jdk-1.5-parent -> push-parent-jdk-1.5 -> containing all but the cometd artifact wicketstuff-core -> jdk-1.6-parent -> push-parent-jdk-1.6 -> containing the comentd artifact.

If there is a dependency from the cometd artifact to the java 5 push artifacts it can be resolved by building the java 5 artifacts first (both in hudson and when the release is cut).

Regards,

Mike



Regarding this patch..

Michael: how would you deal with a mixed jdk version project?

should we move push-parent to jdk1.5 and disable the
animal-sniffer-maven-plugin for the cometd module?


On Wed, 2010-09-29 at 21:17 +0200, Sebastian wrote:

Thanks. Here you go...


On 29.09.2010 20:21, Rodolfo Hansen wrote:
The current comet code is reliant on servlet 3.0 which in turn requires
java 6.

You are correct regarding the timer implementation,

If you send a patch separating the cometd out, so the rest of push can
be java5. I'll push it, but push-parent trunk compiles against wicket
1.5....


   On Wed, 2010-09-29 at 20:01 +0200, Sebastian wrote:

Hi Mike,

thanks for your resoponse. Maybe you can just have the push-comet module
being compiled with Java 6? I am using the push.timer implementation
currently. I recompiled it using Java5 and it works fine.

Regards,

Seb

On 29.09.2010 19:55, Michael O'Cleirigh wrote:
Hi Sebastian,

Its related to the dependencies of the wicketstuff-push. When I switched
the wicketstuff build to use a real JDK 5 instead of JDK 6 in
compatibility mode errors like this were seen:

[INFO]
------------------------------------------------------------------------
[INFO] Error for project: Wicketstuff Push (during deploy)
[INFO]
------------------------------------------------------------------------
[INFO] Compilation failure
/home/wicket/.hudson/jobs/Wicket Stuff
Core/workspace/wicketstuff-core/push-parent/push/src/main/java/org/wicketstuff/push/cometd/CometdService.java:[11,-1]
cannot access org.cometd.bayeux.Channel
bad class file:
/home/wicket/.m2/repository/org/cometd/java/bayeux-api/2.0.0.RC2/bayeux-api-2.0.0.RC2.jar(org/cometd/bayeux/Channel.class)

class file has wrong version 50.0, should be 49.0
*
*This is why the project was moved to be built by java 6 instead of java 5.

Regards,

Mike
*
*
Hi,

why is the wicket push module available in the Maven repo1 compiled
with Java 6? I checked out the code and cannot find a single usage of
any new Java 6 features (except the @Override annotation used on
methods of implemented interfaces).

I'm currently working in an environment where only Java 5 is allowed.
all other wicket components retrieved via Maven repo1 work fine here.

Regards,
Seb


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org




---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org




---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Reply via email to