No, it doesn't.
He already said: The change is small and backwards-compatible.
And the patch looks OK.

On Wed, May 11, 2011 at 11:24 PM, James Carman
<jcar...@carmanconsulting.com> wrote:
> Would it break other people's existing code?
> On May 11, 2011 5:13 PM, "Russell Morrisey" <russell.morri...@missionse.com>
> wrote:
>> I created a patch in order to replace ModalWindow's window-closing
> behavior with a custom IBehavior implementation. The .patch file and a
> quickstart project are included in the JIRA issue:
>>
>> https://issues.apache.org/jira/browse/WICKET-3630
>>
>> Could someone who is a committer to wicket-extensions please review this
> patch, and push it into the next minor wicket release?
>>
>> The code for the next major release of our project relies on this patch.
> Currently we are maintaining our own local copy of ModalWindow.java; I would
> like to eliminate this maintenance burden from our project, and let others
> benefit from the change.
>>
>> The change is small and backwards-compatible, and I'm confident that it's
> solid. If you see any issues with it, please let me know.
>>
>> Thanks, guys,
>>
>> RUSSELL E. MORRISEY
>> Programmer Analyst Professional
>> Mission Solutions Engineering, LLC
>>
>> | russell.morri...@missionse.com | www.missionse.com
>> 304 West Route 38, Moorestown, NJ 08057-3212
>>
>>
>> -----Original Message-----
>> From: users-digest-h...@wicket.apache.org [mailto:
> users-digest-h...@wicket.apache.org]
>> Sent: Wednesday, May 11, 2011 10:40 AM
>> To: users@wicket.apache.org
>> Subject: users Digest 11 May 2011 14:40:22 -0000 Issue 3224
>>
>>
>> users Digest 11 May 2011 14:40:22 -0000 Issue 3224
>>
>> Topics (messages 63002 through 63031):
>>
>> Table not refreshed - ajax debug shows right markup returned
>> 63002 by: D D
>> 63003 by: Martin Grigorov
>> 63004 by: D D
>> 63005 by: Martin Grigorov
>> 63009 by: D D
>> 63010 by: Martin Grigorov
>>
>> Re: Error with FileUpload: "ServletRequest does not contain multipart
> content"
>> 63006 by: eugenebalt
>> 63007 by: Martin Grigorov
>> 63008 by: eugenebalt
>>
>> Re: Nothing happens on AJAX call after session timeout
>> 63011 by: Gabriel Landon
>> 63014 by: vov
>> 63015 by: Martin Grigorov
>> 63018 by: vov
>>
>> disabled chek box form submit
>> 63012 by: fachhoch
>> 63013 by: Martin Makundi
>> 63019 by: Andrea Del Bene
>>
>> Selenium Problem
>> 63016 by: rawe
>> 63017 by: Martin Grigorov
>> 63020 by: rawe
>>
>> Questions Regarding Wicket URL Generation
>> 63021 by: Carlo Camerino
>> 63022 by: Andrea Del Bene
>> 63023 by: Martin Grigorov
>> 63024 by: Andrea Del Bene
>> 63025 by: Clint Checketts
>>
>> [announce] Wicket 1.5-RC4.2 is released
>> 63026 by: Martin Grigorov
>>
>> ModalWindow with Panel - HeaderContributor in Panel not called
>> 63027 by: Marieke Vandamme
>>
>> FileUploadField Losing Value After Form Submit
>> 63028 by: eugenebalt
>> 63029 by: Andrea Del Bene
>> 63030 by: eugenebalt
>>
>> FileUploadField.getClientFileName() doesn't give Absolute Path
>> 63031 by: eugenebalt
>>
>> Administrivia:
>>
>> ---------------------------------------------------------------------
>> To post to the list, e-mail: users@wicket.apache.org To unsubscribe,
> e-mail: users-digest-unsubscr...@wicket.apache.org
>> For additional commands, e-mail: users-digest-h...@wicket.apache.org
>>
>> ----------------------------------------------------------------------
>>
>>
>> This is a PRIVATE message. If you are not the intended recipient, please
> delete without copying and kindly advise us by e-mail of the mistake in
> delivery.
>> NOTE: Regardless of content, this e-mail shall not operate to bind MSE to
> any order or other contract unless pursuant to explicit written agreement or
> government initiative expressly permitting the use of e-mail for such
> purpose.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>> For additional commands, e-mail: users-h...@wicket.apache.org
>>
>



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Reply via email to