Hi, On Tue, Dec 18, 2012 at 10:41 AM, Thijs <[email protected]> wrote:
> Hi, > > I'm trying to revive Wicket Portlets support and I'm running into a small > issue. For Liferay i've got my old 1.4 portlets working 90% with Wicket 6 > but I'm hitting a small problem with the UrlRenderer and WebServletResponse > > WebServletResponse does an optimization for tomcat in the sendRedirect > method. it strips the "./" from the url. However in the case of portlet > this causes a endless loop in some scenarios. Would it be possible to put > this "optimization" in the UrlRenderer? So that we can choose to override > this by providing a custom PortletUrlRenderer. > Please send a .patch that fixes the issue for Portlets and still keeps all the tests green. > > While digging into this I also came a cross another thing. > WebServletResponse.**encodeRedirectURL(url) uses "new > UrlRenderer(webRequest)" while WebServletResponse. encodeUrl(url) uses the > RequestCycle.get().**getUrlRenderer(). Why doesn't > WebServletResponse.**encodeRedirectURL(url) > use RequestCycle.get().**getUrlRenderer(). As this last method gives the > custom UrlRenderer back that we use in the PortletRequestCylce instead of > just the default. > Because at this point there is no RequestCycle. http://markmail.org/thread/qsdfhrbowb5tszxr I chose the simpler solution to create a new UrlRenderer. It seems we will need to extend the life of RequestCycle or create a completely new one just for getting a proper UrlRenderer. > > Kind regard > > Thijs > > ------------------------------**------------------------------**--------- > To unsubscribe, e-mail: > users-unsubscribe@wicket.**apache.org<[email protected]> > For additional commands, e-mail: [email protected] > > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com <http://jweekend.com/>
