I see the good point in it but in the moment when I needed a different
behaviour it is still final. No one will wait for the next release if
you have to do it now.
Bye,
Oliver
Am 07.01.14 16:54, schrieb Martin Grigorov:
http://wicket.sourceforge.net/faqs.html#why-final
this is the explanation of the designers of Wicket
I agree with both sides
I don't think that there are too many finals in the code
usually if you explain why you need to remove the final we either remove it
for the next release or explain a better way
Sven asked for the reason already
Martin Grigorov
Wicket Training and Consulting
On Tue, Jan 7, 2014 at 5:21 PM, Steve <shadders....@gmail.com> wrote:
Have to agree with this. I've come across the 'final' issues many times
in wicket and other libraries. It appears from my own experience with
Wicket is that classes/methods are marked final if the developer can't
think of a reason someone might want to extend it (Martin, I'm not
actually referring to RawMarkup here, there's many other cases I've
encountered both in wicket-el and completely unrelated coding
adventures). IMHO this is an artificial limitation and they should
only be marked final if the expected results of that method form part of
a contract that could be broken if the behaviour of the implementing
method differs from the original. In that case it is the responsibility
of the overrider to deal with the implications ultimately but if can be
dealt with explaining the contract clearly in the javadoc. That way if
a downstream developer mucks it up it's on their own head and the wicket
devs don't have to deal with the fallout of buggered up design.
Again IMHO there are very few legitimate use cases for marking methods
or classes final in an OS library. Closed source I can understand.
On 08/01/14 00:53, Oliver B. Fischer wrote:
There are to much final methods in Wicket. This leads to copying code
instead of overriding only the methods you would like to change.
Oliver
Am 07.01.14 15:44, schrieb Martin Grigorov:
On Tue, Jan 7, 2014 at 4:42 PM, Martin Grigorov
<mgrigo...@apache.org>wrote:
Hi,
It is no more final in 7.x.
Actually it is still final.
I have been confused with another method.
I don't mind removing final in 6.x too.
Martin Grigorov
Wicket Training and Consulting
On Tue, Jan 7, 2014 at 4:37 PM, Oliver B. Fischer
<mails...@swe-blog.net>wrote:
Hi,
I just tried to customize EnumChoiceRenderer and to override
getDisplayValue, but is final. Why?
Can I submit a patch to remove final?
Bye,
Oliver
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org
