Well.... I have not tried adding a CDATA but I do not see why it should not work... My point is backward compatibility. As a user this is an "unexpected" change: I just upgrade my application and it suddenly stops working.
On Mon, Feb 24, 2014 at 10:59 AM, Martin Grigorov <mgrigo...@apache.org>wrote: > On Mon, Feb 24, 2014 at 11:56 AM, Ernesto Reinaldo Barreiro < > reier...@gmail.com> wrote: > > > 3) was what i have suggested in issue... wicket:nosacan="true".... but > for > > backward compatibility it would be nice if it the other way around. > > wicket:scan='true' > > > > The question is: is it really needed ? I'd like to avoid adding more custom > attributes if there is a way to avoid it. > does 1) or 2) solve the issue ? > > > > > > > > On Mon, Feb 24, 2014 at 9:11 AM, Martin Grigorov <mgrigo...@apache.org > > >wrote: > > > > > Hi Ernesto, > > > > > > > > > On Sat, Feb 22, 2014 at 8:46 AM, Ernesto Reinaldo Barreiro < > > > reier...@gmail.com> wrote: > > > > > > > On Wicket 6.13.0 following code > > > > > > > > <script type="text/template" id="message-template"> > > > > <div class="sender pull-left"> > > > > <div class="icon"> > > > > <img src="img/2.jpg" class="img-circle" alt=""/> > > > > </div> > > > > <div class="time"> > > > > just now > > > > </div> > > > > </div> > > > > <div class="chat-message-body"> > > > > <span class="arrow"></span> > > > > <div class="sender">Tikhon Laninga</div> > > > > <div class="text"> > > > > <%- text %> > > > > > > > > > > The problem should be here. > > > Wicket's XmlPullParser is XML parser, not HTML parser, and it doesn't > > know > > > that the content in <script> tags should be read as plain text. > > > <% is invalid XML tag name. > > > > > > Solutions: > > > > > > 1) replace <% %> with different delimiters. > > > I am not sure which templating library you use but I know few JS libs > > that > > > support this. > > > > > > 2) wrap the content of the <script> in CDATA > > > > > > 3) adding a new wicket:xyz attribute that will tell Wicket to not > process > > > the children of <script> > > > > > > > > > > </div> > > > > </div> > > > > </script> > > > > > > > > was parsed OK. On Wicket 6.14.0 I get > > > > > > > > ====================================================== > > > > > > > > 2014-02-22 07:42:48,618 [qtp757902664-22] ERROR > > > > [org.apache.wicket.DefaultExceptionMapper] - Unexpected error > occurred > > > > org.apache.wicket.markup.MarkupException: Malformed tag (line 73, > > column > > > > 17) > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.AbstractMarkupParser.parseMarkup(AbstractMarkupParser.java:301) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.AbstractMarkupParser.parse(AbstractMarkupParser.java:183) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.loader.SimpleMarkupLoader.loadMarkup(SimpleMarkupLoader.java:51) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.loader.InheritedMarkupMarkupLoader.loadMarkup(InheritedMarkupMarkupLoader.java:57) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.loader.DefaultMarkupLoader.loadMarkup(DefaultMarkupLoader.java:52) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > org.apache.wicket.markup.MarkupFactory.loadMarkup(MarkupFactory.java:412) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > org.apache.wicket.markup.MarkupCache.loadMarkup(MarkupCache.java:448) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.MarkupCache.loadMarkupAndWatchForChanges(MarkupCache.java:544) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > org.apache.wicket.markup.MarkupCache.getMarkup(MarkupCache.java:305) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > org.apache.wicket.markup.MarkupFactory.getMarkup(MarkupFactory.java:236) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.loader.InheritedMarkupMarkupLoader.getBaseMarkup(InheritedMarkupMarkupLoader.java:99) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.loader.InheritedMarkupMarkupLoader.loadMarkup(InheritedMarkupMarkupLoader.java:68) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.loader.DefaultMarkupLoader.loadMarkup(DefaultMarkupLoader.java:52) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > org.apache.wicket.markup.MarkupFactory.loadMarkup(MarkupFactory.java:412) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > org.apache.wicket.markup.MarkupCache.loadMarkup(MarkupCache.java:448) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.MarkupCache.loadMarkupAndWatchForChanges(MarkupCache.java:544) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > org.apache.wicket.markup.MarkupCache.getMarkup(MarkupCache.java:305) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > org.apache.wicket.markup.MarkupFactory.getMarkup(MarkupFactory.java:236) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > org.apache.wicket.markup.MarkupFactory.getMarkup(MarkupFactory.java:194) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.MarkupContainer.getAssociatedMarkup(MarkupContainer.java:405) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at org.apache.wicket.Component.getMarkup(Component.java:728) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at org.apache.wicket.Component.internalRender(Component.java:2346) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at org.apache.wicket.Component.render(Component.java:2309) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at org.apache.wicket.Page.renderPage(Page.java:1024) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.request.handler.render.WebPageRenderer.renderPage(WebPageRenderer.java:121) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.request.handler.render.WebPageRenderer.respond(WebPageRenderer.java:274) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.core.request.handler.RenderPageRequestHandler.respond(RenderPageRequestHandler.java:175) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:862) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.request.RequestHandlerStack.execute(RequestHandlerStack.java:64) > > > > ~[wicket-request-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:261) > > > > [wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:218) > > > > [wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.request.cycle.RequestCycle.processRequestAndDetach(RequestCycle.java:289) > > > > [wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:259) > > > > [wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:201) > > > > [wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:282) > > > > [wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.springframework.orm.jpa.support.OpenEntityManagerInViewFilter.doFilterInternal(OpenEntityManagerInViewFilter.java:180) > > > > [spring-orm-3.2.4.RELEASE.jar:3.2.4.RELEASE] > > > > at > > > > > > > > > > > > > > org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) > > > > [spring-web-3.2.4.RELEASE.jar:3.2.4.RELEASE] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1474) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:499) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:428) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at org.eclipse.jetty.server.Server.handle(Server.java:370) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:489) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.server.BlockingHttpConnection.handleRequest(BlockingHttpConnection.java:53) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:949) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:1011) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:644) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.server.BlockingHttpConnection.handle(BlockingHttpConnection.java:72) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.server.bio.SocketConnector$ConnectorEndPoint.run(SocketConnector.java:264) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at > > > > > > > > > > > > > > org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543) > > > > [jetty-all-server-8.1.13.v20130916.jar:8.1.13.v20130916] > > > > at java.lang.Thread.run(Thread.java:744) [na:1.7.0_45] > > > > Caused by: java.text.ParseException: Malformed tag (line 73, column > 17) > > > > at > > > > > > > > > > org.apache.wicket.markup.parser.XmlPullParser.next(XmlPullParser.java:320) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.filter.RootMarkupFilter.nextElement(RootMarkupFilter.java:72) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.filter.OpenCloseTagExpander.nextElement(OpenCloseTagExpander.java:79) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.parser.AbstractMarkupFilter.nextElement(AbstractMarkupFilter.java:91) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.AbstractMarkupParser.getNextTag(AbstractMarkupParser.java:215) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > at > > > > > > > > > > > > > > org.apache.wicket.markup.AbstractMarkupParser.parseMarkup(AbstractMarkupParser.java:230) > > > > ~[wicket-core-6.14.0.jar:6.14.0] > > > > ... 60 common frames omitted > > > > > > > > ============================================================== > > > > > > > > Is this a regression or a new feature? > > > > > > > > > > > > -- > > > > Regards - Ernesto Reinaldo Barreiro > > > > > > > > > > > > > > > -- > > Regards - Ernesto Reinaldo Barreiro > > > -- Regards - Ernesto Reinaldo Barreiro