https://github.com/cortix/project/pull/1

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Mon, Jan 12, 2015 at 3:52 PM, Hasan Çelik <hsnclk1...@gmail.com> wrote:

> Sorry about that, it's my fault, I didn't know that it was about
> wicket-bootstrap... By the way
>
> I googled and I have found that
>
> https://github.com/l0rdn1kk0n/wicket-bootstrap/issues/385
>
> But I didnt override newBrandNameLink in the BasePage...Where should I
> override it ?
>
> Thank you so much for these information and your patience
>
> Best Regards
>
>
>
> Web Sitesi : www.ab-hibe.com
> E-mail: hasance...@berkadem.com
> E-mail: i...@ab-hibe.com
> Gsm1: 0 544 640 96 25
> Adres : 1271. Sokak 33/14 Sabri Mermutlu İş Merkezi Balgat Ankara
>
> On Mon, Jan 12, 2015 at 3:15 PM, Martin Grigorov <mgrigo...@apache.org>
> wrote:
>
> > Hi,
> >
> > Please read again what I've explained in my previous mail.
> > Your 'brandName' component is broken.
> > 1) It is a <span>. Must be <a>
> > 2) It is not needed at all. You see Bootstrap's brandName link in the
> > produced UI. Your custom brand name produces <span ...></span> without
> any
> > text so you don't see it in the UI at all.
> > 3) read Bootstrap docs for expected HTML template for Navbar and check it
> > against what your application produces.
> > 4) You need to override
> >
> >
> https://github.com/l0rdn1kk0n/wicket-bootstrap/blob/master/bootstrap-core/src/main/java/de/agilecoders/wicket/core/markup/html/bootstrap/navbar/Navbar.java#L229
> > instead of using your own component for brandName. Your first messages
> > didn't explain that you use Wicket-Bootstrap so I wasn't able to suggest
> > you this then
> >
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
> >
> > On Mon, Jan 12, 2015 at 2:08 PM, Hasan Çelik <hsnclk1...@gmail.com>
> wrote:
> >
> > > Hi Martin,
> > >
> > > The reason why I'm using two BasePage, When the members visit the
> > website ,
> > > I want to show only BasePage1 menu
> > >
> > > When the visitor login in , I want to show the Management Page menu
> > > (BasePage2)... but problem is, when they login in, if they click the
> > > brandname, wicket forward them to HomePage...I don't want to do this :(
> > so
> > > I try to override brandname link in every BasePage... I used your
> saying
> > > but it doesn't work
> > >
> > > class BasePage {
> > >
> > >   @Override protected void onInitialize() {super.onInitialize();
> > > add(brandLink("brandLink"))}
> > >
> > >   protected abstract AbstractLink brandLink(String id);
> > > }
> > >
> > > class BasePage1 extend BasePage {
> > >   ...
> > >   protected BookmarkablePageLink brandLink(String id) {return new
> > > BookmarkablePageLink(id, IndexPage.class)}
> > > }
> > >
> > > class BasePage2 extend BasePage {
> > >   ...
> > >   protected BookmarkablePageLink brandLink(String id) {return new
> > > BookmarkablePageLink(id, ManagementPage.class)}
> > > }
> > >
> > > Regards
> > >
> > >
> > >
> > > Web Sitesi : www.ab-hibe.com
> > > E-mail: hasance...@berkadem.com
> > > E-mail: i...@ab-hibe.com
> > > Gsm1: 0 544 640 96 25
> > > Adres : 1271. Sokak 33/14 Sabri Mermutlu İş Merkezi Balgat Ankara
> > >
> > > On Sun, Jan 11, 2015 at 11:18 PM, Martin Grigorov <
> mgrigo...@apache.org>
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > Yes, it works. It produces HTML like (check the produced HTML in your
> > > app):
> > > > <span onclick="var win = this.ownerDocument.defaultView ||
> > > > this.ownerDocument.parentWindow; if (win == window) {
> > > > window.location.href='./management'; } ;return false"></span>
> > > >
> > > > Not sure why but you use your custom HTML element for the brand name,
> > and
> > > > it is a <span>:
> > > >
> > > >
> > >
> >
> https://github.com/cortix/project/blob/master/src/main/java/web/BasePage.html#L13
> > > >
> > > > I see you use Wicket-Bootstrap. It's Navbar component provides a
> > factory
> > > > method for the brand name link:
> > > >
> > > >
> > >
> >
> https://github.com/l0rdn1kk0n/wicket-bootstrap/blob/master/bootstrap-core/src/main/java/de/agilecoders/wicket/core/markup/html/bootstrap/navbar/Navbar.java#L229
> > > > Just use it. No need to add your own one.
> > > > Check http://getbootstrap.com/components/#navbar-default for more
> > about
> > > > Bootstrap's expacted HTML.
> > > >
> > > >
> > > >
> > > > Martin Grigorov
> > > > Wicket Training and Consulting
> > > > https://twitter.com/mtgrigorov
> > > >
> > > > On Sun, Jan 11, 2015 at 9:55 PM, Hasan Çelik <hsnclk1...@gmail.com>
> > > wrote:
> > > >
> > > > > Hi Martin,
> > > > >
> > > > > Thanks for reply, In the future I may use these pages...brandname
> > link
> > > > > doesn't work...Afer I click Management.page, I check the brandlink
> > but
> > > > > again it forward the Homepage... What I want to do,
> > > > >
> > > > > when I click ManagementPage, brandlink ---> /management
> > > > > when I click HomePage, brandlink ---> /index
> > > > >
> > > > > I hope, I made myself clear
> > > > >
> > > > > Regards
> > > > >
> > > > >
> > > > >
> > > > > Web Sitesi : www.ab-hibe.com
> > > > > E-mail: hasance...@berkadem.com
> > > > > E-mail: i...@ab-hibe.com
> > > > > Gsm1: 0 544 640 96 25
> > > > > Adres : 1271. Sokak 33/14 Sabri Mermutlu İş Merkezi Balgat Ankara
> > > > >
> > > > > On Sun, Jan 11, 2015 at 10:45 PM, Martin Grigorov <
> > > mgrigo...@apache.org>
> > > > > wrote:
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > There is no need to provide BasePage1.html and BasePage2.html at
> > all.
> > > > > > If there is no specific html for a page then Wicket will use the
> > > markup
> > > > > of
> > > > > > the parent page (i.e. BasePage.html)
> > > > > >
> > > > > >
> > > > > > Martin Grigorov
> > > > > > Wicket Training and Consulting
> > > > > > https://twitter.com/mtgrigorov
> > > > > >
> > > > > > On Fri, Jan 9, 2015 at 4:09 PM, Hasan Çelik <
> hsnclk1...@gmail.com>
> > > > > wrote:
> > > > > >
> > > > > > > *Hi,*
> > > > > > >
> > > > > > > * I replied my old question but it didn't exist in the forum
> and
> > I
> > > > > > choosed
> > > > > > > this way, sorry about that, I wanted to remind
> dioalog...Anyway I
> > > > asked
> > > > > > > this question before,*
> > > > > > >
> > ------------------------------------------------------------------
> > > > > > > Hi,
> > > > > > >
> > > > > > > Normally I have one Base Page, but I want to create more than
> > one..
> > > > > > >
> > > > > > > For example
> > > > > > >
> > > > > > > LoginPage extend BasePage1
> > > > > > > ManagmentPage extend BasePage2
> > > > > > >
> > > > > > > A user login in the website, redirect to ManagementPage... but
> > > when
> > > > > user
> > > > > > > click BrandName,  redirect to LoginPage ...Can I change the
> > > brandname
> > > > > for
> > > > > > > other BasePages
> > > > > > >
> > > > > > > For example
> > > > > > >
> > > > > > > In the ManagmentPage brandName link may be/managementPage ,
> > > > > > > In the LoginPage brandName link may be /index
> > > > > > >
> > > > > > > Is there a way to change it ?
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> ---------------------------------------------------------------------------------------------
> > > > > > > *Martin Grigorov  said*
> > > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > class BasePage {
> > > > > > >
> > > > > > >   @Override protected void onInitialize()
> {super.onInitialize();
> > > > > > > add(brandLink("brandLink"))}
> > > > > > >
> > > > > > >   protected abstract AbstractLink brandLink(String id);
> > > > > > > }
> > > > > > >
> > > > > > > class BasePage1 extend BasePage {
> > > > > > >   ...
> > > > > > >   protected BookmarkablePageLink brandLink(String id) {return
> new
> > > > > > > BookmarkablePageLink(id, IndexPage.class)}
> > > > > > > }
> > > > > > >
> > > > > > > class BasePage2 extend BasePage {
> > > > > > >   ...
> > > > > > >   protected BookmarkablePageLink brandLink(String id) {return
> new
> > > > > > > BookmarkablePageLink(id, ManagementPage.class)}
> > > > > > > }
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> --------------------------------------------------------------------------------------
> > > > > > > According to this reply,
> > > > > > >
> > > > > > > I want to ask another question,
> > > > > > >
> > > > > > > Hi Martin,
> > > > > > >
> > > > > > > If I use these construction, How can I change my BasePage
> markup
> > > and
> > > > > java
> > > > > > > class
> > > > > > >
> > > > > > > Normally my BasePage.html
> > > > > > >
> > > > > > > https://gist.github.com/cortix/68b584310e9be62de4c6
> > > > > > >
> > > > > > > ​and BasePage.java
> > > > > > >
> > > > > > > https://gist.github.com/cortix/7a5453cddac75b90f29a
> > > > > > >
> > > > > > > According your code, I tried to create new BasePage, BasePage1,
> > > > > BasePage2
> > > > > > >
> > > > > > > but I didn't succeed to create markup for BasePage, BasePage1,
> > > > > BasePage2
> > > > > > > and also java pages...
> > > > > > >
> > > > > > > If BasePage.java would be my main page, How can I edit child
> and
> > > > extend
> > > > > > tag
> > > > > > > for BasePage1, BasePage2
> > > > > > >
> > > > > > > because
> > > > > > >
> > > > > > > LoginPage extend BasePage1
> > > > > > > ManagmentPage extend BasePage2
> > > > > > >
> > > > > > > and
> > > > > > >
> > > > > > > BasePage1 extend BasePage
> > > > > > > BasePage2 extend BasePage
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> -----------------------------------------------------------------------------------
> > > > > > > Martin Grigorov said
> > > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > Please create a quickstart application at GitHub and give us
> the
> > > url.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> ------------------------------------------------------------------------------------
> > > > > > >
> > > > > > > Apologize for delay, I tried to learn to create quick start
> > project
> > > > on
> > > > > > the
> > > > > > > github...
> > > > > > >
> > > > > > > https://github.com/cortix/project
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Reply via email to