HI Maxim, This will lead to a big API break. If we change this signature then we will have to change many more to keep it consistent, and this will lead to a lot of work for the application developers to change AjaxRequestTarget with IPartialPageRequestHandler.
We may need to make this change for Wicket 8.x if there are many users wanting this change, but for now I'd suggest you to create an adapter. Martin Grigorov Freelancer. Available for hire! Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Jul 3, 2015 at 7:46 AM, Maxim Solodovnik <solomax...@gmail.com> wrote: > Hello Martin, > > I guess following method need to be additionally updated: > > org.apache.wicket.ajax.AbstractAjaxTimerBehavior.onTimer > > On Thu, Jul 2, 2015 at 6:11 PM, Martin Grigorov <mgrigo...@apache.org> > wrote: > > > The change is rather big: > > > > > https://github.com/sebfz1/wicket-jquery-ui/commit/e94f89d8f07f2b1af2b327a4aaec5ddd4b1400af > > I guess many other methods will need to be changed too if one needs to > use > > them with WebSocket. > > The improvement in the Wicket API looked so innocent ... > > > > Martin Grigorov > > Freelancer. Available for hire! > > Wicket Training and Consulting > > https://twitter.com/mtgrigorov > > > > On Thu, Jul 2, 2015 at 2:28 PM, Maxim Solodovnik <solomax...@gmail.com> > > wrote: > > > > > Done: https://github.com/sebfz1/wicket-jquery-ui/issues/177 > > > Sorry, forgot about Sebastians vacation :( > > > > > > On Thu, Jul 2, 2015 at 5:23 PM, Martin Grigorov <mgrigo...@apache.org> > > > wrote: > > > > > > > @Maxim: Please create an issue at Wicket jQuery UI github. > > > > Sebastien is on vacation. I can do it but first I need a good reason > > for > > > > the change :-) > > > > > > > > Martin Grigorov > > > > Freelancer. Available for hire! > > > > Wicket Training and Consulting > > > > https://twitter.com/mtgrigorov > > > > > > > > On Thu, Jul 2, 2015 at 12:33 PM, Maxim Solodovnik < > > solomax...@gmail.com> > > > > wrote: > > > > > > > > > @Sebastian could you please modify AbstractDialog.open method to be > > > > > > > > > > public final void open(IPartialPageRequestHandler target) > > > > > instead of > > > > > public final void open(AjaxRequestTarget target) > > > > > > > > > > Thanks in advance! > > > > > > > > > > > > > > > On Thu, Jul 2, 2015 at 2:58 PM, Martin Grigorov < > > mgrigo...@apache.org> > > > > > wrote: > > > > > > > > > > > Yes, another minor cleanup: there is now > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPartialPageRequestHandler.java > > > > > > A base interface for Ajax and WebSocket. > > > > > > > > > > > > Martin Grigorov > > > > > > Freelancer. Available for hire! > > > > > > Wicket Training and Consulting > > > > > > https://twitter.com/mtgrigorov > > > > > > > > > > > > On Thu, Jul 2, 2015 at 11:45 AM, Maxim Solodovnik < > > > > solomax...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > Additionally it looks like WebSocketRequestHandler can not be > > used > > > > > > > as AjaxRequestTarget any longer > > > > > > > Previously it was possible to use WebSocketRequestHandler to > push > > > > > updated > > > > > > > component ..... > > > > > > > > > > > > > > On Thu, Jul 2, 2015 at 2:42 PM, Maxim Solodovnik < > > > > solomax...@gmail.com > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Thanks a lot Tobias! > > > > > > > > > > > > > > > > On Thu, Jul 2, 2015 at 1:03 PM, Tobias Soloschenko < > > > > > > > > tobiassolosche...@googlemail.com> wrote: > > > > > > > > > > > > > > > >> Hi Maxim, > > > > > > > >> > > > > > > > >> no problem I am going to add the getter this evening. Thank > > you > > > > for > > > > > > your > > > > > > > >> suggestions! :-) > > > > > > > >> > > > > > > > >> Maybe the SNAPSHOT isn't refreshed because of the downtime > of > > > the > > > > > > > >> buildbot server. However the build was triggered already. > > > > > > > >> > > > > > > > >> kind regards > > > > > > > >> > > > > > > > >> Tobias > > > > > > > >> > > > > > > > >> > Am 02.07.2015 um 08:45 schrieb Maxim Solodovnik < > > > > > > solomax...@gmail.com > > > > > > > >: > > > > > > > >> > > > > > > > > >> > Thanks a lot for the changes Tobias, > > > > > > > >> > Unfortunately I'm unable to test it due to latest > > > 7.0.0-SNAPSHOT > > > > > > seems > > > > > > > >> > doesn't contain it :( > > > > > > > >> > > > > > > > > >> > And one more question: I would like to be able to modify > > > > > > > PageParameters > > > > > > > >> > passed to source, maybe it would be possible to add public > > > > getter > > > > > > for > > > > > > > >> it? > > > > > > > >> > > > > > > > > >> > Thanks in advance > > > > > > > >> > > > > > > > > >> > On Mon, Jun 29, 2015 at 9:41 PM, Tobias Soloschenko < > > > > > > > >> > tobiassolosche...@googlemail.com> wrote: > > > > > > > >> > > > > > > > > >> >> Hi Maxim, > > > > > > > >> >> > > > > > > > >> >> hope the change is like you wanted it to be: > > > > > > > >> >> > > > > > > > >> >> > > > > > > > >> >> > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/wicket/commit/e20bfa738aa64f35b668f05866e0c0b7ca71c1f4 > > > > > > > >> >> > > > > > > > >> >> But again: The PackageResourceReference is best practice, > > > > because > > > > > > you > > > > > > > >> also > > > > > > > >> >> can use "readBuffered(false)" of it - with this option > the > > > > > resource > > > > > > > is > > > > > > > >> >> streamed directly without loading it into memory. For > more > > > > > > > information > > > > > > > >> >> refer to the Javadoc of the method. > > > > > > > >> >> > > > > > > > >> >> kind regards > > > > > > > >> >> > > > > > > > >> >> Tobias > > > > > > > >> >> > > > > > > > >> >>> Am 29.06.15 um 10:22 schrieb Maxim Solodovnik: > > > > > > > >> >>> > > > > > > > >> >>> Thanks a lot! > > > > > > > >> >>> It was gmail SPAM filter :((( > > > > > > > >> >>> will do migration and examine examples > > > > > > > >> >>> > > > > > > > >> >>> On Mon, Jun 29, 2015 at 2:18 PM, Martin Grigorov < > > > > > > > >> mgrigo...@apache.org> > > > > > > > >> >>> wrote: > > > > > > > >> >>> > > > > > > > >> >>> For some reason Tobias' mails are marked as SPAM by > > GMail... > > > > > > > >> >>>> > > > > > > > >> >>>> Martin Grigorov > > > > > > > >> >>>> Freelancer. Available for hire! > > > > > > > >> >>>> Wicket Training and Consulting > > > > > > > >> >>>> https://twitter.com/mtgrigorov > > > > > > > >> >>>> > > > > > > > >> >>>> On Mon, Jun 29, 2015 at 11:15 AM, Maxim Solodovnik < > > > > > > > >> solomax...@gmail.com > > > > > > > >> >>>>> > > > > > > > >> >>>> wrote: > > > > > > > >> >>>> > > > > > > > >> >>>> sorry, most probably missed that email > > > > > > > >> >>>>> Thanks! > > > > > > > >> >>>>> > > > > > > > >> >>>>> On Mon, Jun 29, 2015 at 2:14 PM, Martin Grigorov < > > > > > > > >> mgrigo...@apache.org> > > > > > > > >> >>>>> wrote: > > > > > > > >> >>>>> > > > > > > > >> >>>>> Tobias already explained that it was an oversight and > he > > > is > > > > > > going > > > > > > > to > > > > > > > >> >>>>>> improve it tonight. > > > > > > > >> >>>>>> > > > > > > > >> >>>>>> Martin Grigorov > > > > > > > >> >>>>>> Freelancer. Available for hire! > > > > > > > >> >>>>>> Wicket Training and Consulting > > > > > > > >> >>>>>> https://twitter.com/mtgrigorov > > > > > > > >> >>>>>> > > > > > > > >> >>>>>> On Mon, Jun 29, 2015 at 11:10 AM, Maxim Solodovnik < > > > > > > > >> >>>>>> > > > > > > > >> >>>>> solomax...@gmail.com > > > > > > > >> >>>> > > > > > > > >> >>>>> wrote: > > > > > > > >> >>>>>> > > > > > > > >> >>>>>> Thanks Martin :) > > > > > > > >> >>>>>>> will look through sources :) > > > > > > > >> >>>>>>> > > > > > > > >> >>>>>>> can you please tell me why PackageResourceReference > is > > > > being > > > > > > > used > > > > > > > >> in > > > > > > > >> >>>>>>> MediaComponent and not ResourceReference? Or maybe > > > Tobias > > > > > can > > > > > > > >> answer > > > > > > > >> >>>>>>> > > > > > > > >> >>>>>> this > > > > > > > >> >>>>> > > > > > > > >> >>>>>> question? > > > > > > > >> >>>>>>> > > > > > > > >> >>>>>>> On Mon, Jun 29, 2015 at 2:00 PM, Martin Grigorov < > > > > > > > >> >>>>>>> > > > > > > > >> >>>>>> mgrigo...@apache.org > > > > > > > >> >>>> > > > > > > > >> >>>>> wrote: > > > > > > > >> >>>>>>> > > > > > > > >> >>>>>>> Everything is possible. > > > > > > > >> >>>>>>>> All I need is longer day. 24 hours are not > enough... > > > > > > > >> >>>>>>>> > > > > > > > >> >>>>>>>> Martin Grigorov > > > > > > > >> >>>>>>>> Freelancer. Available for hire! > > > > > > > >> >>>>>>>> Wicket Training and Consulting > > > > > > > >> >>>>>>>> https://twitter.com/mtgrigorov > > > > > > > >> >>>>>>>> > > > > > > > >> >>>>>>>> On Mon, Jun 29, 2015 at 10:53 AM, Maxim Solodovnik > < > > > > > > > >> >>>>>>>> > > > > > > > >> >>>>>>> solomax...@gmail.com > > > > > > > >> >>>>>> > > > > > > > >> >>>>>>> wrote: > > > > > > > >> >>>>>>>> > > > > > > > >> >>>>>>>> Is it possible update > http://www.wicket-library.com/ > > > to > > > > > have > > > > > > > >> >>>>>>>>> > > > > > > > >> >>>>>>>> wicket7 > > > > > > > >> >>>>> > > > > > > > >> >>>>>> examples as well? > > > > > > > >> >>>>>>>>> I believe this might be very useful :) > > > > > > > >> >>>>>>>>> > > > > > > > >> >>>>>>>>> On Mon, Jun 29, 2015 at 1:49 PM, andrea del bene < > > > > > > > >> >>>>>>>>> > > > > > > > >> >>>>>>>> an.delb...@gmail.com > > > > > > > >> >>>>>> > > > > > > > >> >>>>>>> wrote: > > > > > > > >> >>>>>>>>> > > > > > > > >> >>>>>>>>> Hi, > > > > > > > >> >>>>>>>>>> > > > > > > > >> >>>>>>>>>> in wicket-examples take a look at the project in > > > > > > > >> >>>>>>>>>> org.apache.wicket.examples.media > > > > > > > >> >>>>>>>>>> > > > > > > > >> >>>>>>>>>> Andrea. > > > > > > > >> >>>>>>>>>> > > > > > > > >> >>>>>>>>>> > > > > > > > >> >>>>>>>>>> On 29/06/2015 06:47, Maxim Solodovnik wrote: > > > > > > > >> >>>>>>>>>> > > > > > > > >> >>>>>>>>>> Hello All, > > > > > > > >> >>>>>>>>>>> > > > > > > > >> >>>>>>>>>>> Recently I have upgraded to Wicket+wicketstuff > > > > 7.0.0-M6 > > > > > > and > > > > > > > >> >>>>>>>>>>> > > > > > > > >> >>>>>>>>>> found > > > > > > > >> >>>>> > > > > > > > >> >>>>>> lots > > > > > > > >> >>>>>>> > > > > > > > >> >>>>>>>> of > > > > > > > >> >>>>>>>>> > > > > > > > >> >>>>>>>>>> improvements: > > > > > > > >> >>>>>>>>>>> 1) AbstractResource is now supports > > "content-range" > > > > and > > > > > > > >> >>>>>>>>>>> > > > > > > > >> >>>>>>>>>> "accept-range" > > > > > > > >> >>>>>>> > > > > > > > >> >>>>>>>> which is great! I'll remove my custom code for this > > :) > > > > > > > >> >>>>>>>>>>> 2) HTML5 Video is supported by wicket itself > (was > > > > > removed > > > > > > > from > > > > > > > >> >>>>>>>>>>> wicketstuff) > > > > > > > >> >>>>>>>>>>> which is great :)) > > > > > > > >> >>>>>>>>>>> > > > > > > > >> >>>>>>>>>>> 3) MediaComponent requires > > > *PackageResourceReference* > > > > as > > > > > > > >> >>>>>>>>>>> > > > > > > > >> >>>>>>>>>> resourceReference > > > > > > > >> >>>>>>>>> > > > > > > > >> >>>>>>>>>> :(( why it can't be ResourceReference? > > > > > > > >> >>>>>>>>>>> > > > > > > > >> >>>>>>>>>>> Are there any examples in wicket7 regarding new > > > Video > > > > > > > >> >>>>>>>>>>> > > > > > > > >> >>>>>>>>>> Component? > > > > > > > >> >>>> > > > > > > > >> >>>>> Thanks in advance! > > > > > > > >> >>>>>>>>>>> > > > > > > > >> >>>>>>>>>>> > > > > > > > >> >>>>>>>>>>> > > > > > > > >> >>>>>>>>>> > > > > > > > >> >>>>>> > > > > > > > >> > > > > > > --------------------------------------------------------------------- > > > > > > > >> >>>>>> > > > > > > > >> >>>>>>> To unsubscribe, e-mail: > > > > users-unsubscr...@wicket.apache.org > > > > > > > >> >>>>>>>>>> For additional commands, e-mail: > > > > > > > users-h...@wicket.apache.org > > > > > > > >> >>>>>>>>>> > > > > > > > >> >>>>>>>>>> > > > > > > > >> >>>>>>>>>> > > > > > > > >> >>>>>>>>> -- > > > > > > > >> >>>>>>>>> WBR > > > > > > > >> >>>>>>>>> Maxim aka solomax > > > > > > > >> >>>>>>>>> > > > > > > > >> >>>>>>>>> > > > > > > > >> >>>>>>> > > > > > > > >> >>>>>>> -- > > > > > > > >> >>>>>>> WBR > > > > > > > >> >>>>>>> Maxim aka solomax > > > > > > > >> >>>>>>> > > > > > > > >> >>>>>>> > > > > > > > >> >>>>> > > > > > > > >> >>>>> -- > > > > > > > >> >>>>> WBR > > > > > > > >> >>>>> Maxim aka solomax > > > > > > > >> >>>>> > > > > > > > >> >>>>> > > > > > > > >> >>> > > > > > > > >> >>> > > > > > > > >> >> > > > > > > > >> >> > > > > > > > > --------------------------------------------------------------------- > > > > > > > >> >> To unsubscribe, e-mail: > > users-unsubscr...@wicket.apache.org > > > > > > > >> >> For additional commands, e-mail: > > > users-h...@wicket.apache.org > > > > > > > >> >> > > > > > > > >> >> > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > -- > > > > > > > >> > WBR > > > > > > > >> > Maxim aka solomax > > > > > > > >> > > > > > > > >> > > > > > > --------------------------------------------------------------------- > > > > > > > >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > > > > > > > >> For additional commands, e-mail: > users-h...@wicket.apache.org > > > > > > > >> > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > WBR > > > > > > > > Maxim aka solomax > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > WBR > > > > > > > Maxim aka solomax > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > WBR > > > > > Maxim aka solomax > > > > > > > > > > > > > > > > > > > > > -- > > > WBR > > > Maxim aka solomax > > > > > > > > > -- > WBR > Maxim aka solomax >
