I just looked into the Image impl. - the issue here is that the image resource 
automatically creates a resource reference if only the model is provided. It 
would be bad to change this behavior.

Anyway I am going to upload the two new components and may you can try / review 
it.

kind regards

Tobias

> Am 24.11.2015 um 14:59 schrieb Sebastien <seb...@gmail.com>:
> 
> "new Image(String, IModel<String>)" does not work with external urls and do
> not support compound model :)
> 
> 
> On Tue, Nov 24, 2015 at 2:29 PM, Martin Grigorov <mgrigo...@apache.org>
> wrote:
> 
>> I am pretty sure "new Image(String, IModel<String>)" was for such use case.
>> Looking at the code in 6.x+ I don't see how it could work though.
>> So it is either my mistake that it ever worked, or it has been broken at
>> some point.
>> 
>> I just want to avoid having more than one way to do the same thing. This
>> will lead to confusion and bad reputation.
>> I don't have time to investigate deeply the history of this right now.
>> 
>> Martin Grigorov
>> Wicket Training and Consulting
>> https://twitter.com/mtgrigorov
>> 
>> On Tue, Nov 24, 2015 at 2:20 PM, Tobias Soloschenko <
>> tobiassolosche...@googlemail.com> wrote:
>> 
>>> Good point - mhh but the issue here is that the information are not
>> stored
>>> within the model Sebastien and Maxim wanted it to be - or am I wrong?
>>> 
>>> kind regards
>>> 
>>> Tobias
>>> 
>>>> Am 24.11.2015 um 14:11 schrieb Martin Grigorov <mgrigo...@apache.org>:
>>>> 
>>>> Hi,
>>>> 
>>>> Just to make it a little bit confusing: have you considered "new
>>>> Image("id", new UrlResourceReference("...")) ?
>>>> 
>>>> Martin Grigorov
>>>> Wicket Training and Consulting
>>>> https://twitter.com/mtgrigorov
>>>> 
>>>> On Tue, Nov 24, 2015 at 1:43 PM, Tobias Soloschenko <
>>>> tobiassolosche...@googlemail.com> wrote:
>>>> 
>>>>> I finished it, yesterday.
>>>>> 
>>>>> Going to push it this evening. (First to my repo and create a pull
>>> request)
>>>>> 
>>>>> kind regards
>>>>> 
>>>>> Tobias
>>>>> 
>>>>>> Am 24.11.2015 um 03:31 schrieb Maxim Solodovnik <
>> solomax...@gmail.com
>>>> :
>>>>>> 
>>>>>> Also thanks from me :)
>>>>>> 
>>>>>>> On Mon, Nov 23, 2015 at 9:17 PM, Sebastien <seb...@gmail.com>
>> wrote:
>>>>>>> 
>>>>>>> Thanks a million Tobias! :)
>>>>>>> 
>>>>>>> On Mon, Nov 23, 2015 at 4:09 PM, Tobias Soloschenko <
>>>>>>> tobiassolosche...@googlemail.com> wrote:
>>>>>>> 
>>>>>>>> Hi,
>>>>>>>> 
>>>>>>>> sounds good - I am going to change the ticket description soon and
>>> try
>>>>> to
>>>>>>>> implement it.
>>>>>>>> 
>>>>>>>> kind regards
>>>>>>>> 
>>>>>>>> Tobias
>>>>>>>> 
>>>>>>>>> Am 23.11.2015 um 15:45 schrieb Sebastien <seb...@gmail.com>:
>>>>>>>>> 
>>>>>>>>> Hi Tobias,
>>>>>>>>> 
>>>>>>>>> Sorry for the late reply, busy day...
>>>>>>>>> 
>>>>>>>>> Actually Image(String id, IModel model, String url) will not help
>> in
>>>>>>> this
>>>>>>>>> case, I need the url to be in the model, but external url doesn't
>>> work
>>>>>>>> with
>>>>>>>>> Image... I was more thinking about an ExternalImage component....
>>>>>>>>> 
>>>>>>>>> Does it make sense to you?
>>>>>>>>> 
>>>>>>>>> Thanks & best regards,
>>>>>>>>> Sebastien.
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> On Mon, Nov 23, 2015 at 6:05 AM, Tobias Soloschenko <
>>>>>>>>> tobiassolosche...@googlemail.com> wrote:
>>>>>>>>> 
>>>>>>>>>> Hi,
>>>>>>>>>> 
>>>>>>>>>> maybe we can extend the normal image and add a constructor
>>>>>>> Image(String
>>>>>>>>>> id, IModel model, String url) so that the url is used in the src
>>>>>>>> attribute
>>>>>>>>>> (like in MediaComponents)
>>>>>>>>>> 
>>>>>>>>>> WDYT?
>>>>>>>>>> 
>>>>>>>>>> kind regards
>>>>>>>>>> 
>>>>>>>>>> Tobias
>>>>>>>>>> 
>>>>>>>>>>> Am 23.11.2015 um 03:45 schrieb Maxim Solodovnik <
>>>>>>> solomax...@gmail.com
>>>>>>>>> :
>>>>>>>>>>> 
>>>>>>>>>>> Actually I'm using "hacky" way:
>>>>>>>>>>> 
>>>>>>>>>>> if (absolute) {
>>>>>>>>>>> profile.add(new
>>>>>>>>>>> WebMarkupContainer("img").add(AttributeModifier.append("alt",
>>>>>>>>>>> Application.getString(5L)), AttributeModifier.append("src",
>>> uri)));
>>>>>>>>>>> } else {
>>>>>>>>>>> profile.add(new Image("img", new
>> ByteArrayResource("image/jpeg") {
>>>>>>>>>>> ..........................
>>>>>>>>>>> 
>>>>>>>>>>> Would love to know if is there any better way
>>>>>>>>>>> 
>>>>>>>>>>>> On Mon, Nov 23, 2015 at 4:34 AM, Sebastien <seb...@gmail.com>
>>>>>>> wrote:
>>>>>>>>>>>> 
>>>>>>>>>>>> Forgot to mention I've read the following wiki, but as it was a
>>>>>>> little
>>>>>>>>>> bit
>>>>>>>>>>>> old I was wondering if there was nothing newer...
>> https://cwiki.apache.org/confluence/display/WICKET/How+to+load+an+external+image
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>>> On Sun, Nov 22, 2015 at 11:31 PM, Sebastien <seb...@gmail.com
>>> 
>>>>>>>> wrote:
>>>>>>>>>>>>> 
>>>>>>>>>>>>> Hi all,
>>>>>>>>>>>>> 
>>>>>>>>>>>>> I cannot find an Image component that could display an image
>>> from
>>>>>>> an
>>>>>>>>>>>>> *external* url, supplied by the model object. My use-case is
>>> that
>>>>> I
>>>>>>>>>> have
>>>>>>>>>>>> a
>>>>>>>>>>>>> user object, which have a gravatarUrl property, and I would
>> like
>>>>> to
>>>>>>>> do
>>>>>>>>>>>>> something like "this.add(new
>> ExternalImage("gravatarUrl"));"...
>>>>>>>>>>>>> 
>>>>>>>>>>>>> Isn't there any component that actually exists which could do
>>>>> this?
>>>>>>>>>>>>> 
>>>>>>>>>>>>> Many thanks in advance,
>>>>>>>>>>>>> Sebastien
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> --
>>>>>>>>>>> WBR
>>>>>>>>>>> Maxim aka solomax
>>> ---------------------------------------------------------------------
>>>>>>>>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>>>>>>>>>> For additional commands, e-mail: users-h...@wicket.apache.org
>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>>>>>>>> For additional commands, e-mail: users-h...@wicket.apache.org
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> --
>>>>>> WBR
>>>>>> Maxim aka solomax
>>>>> 
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>>>>> For additional commands, e-mail: users-h...@wicket.apache.org
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>>> For additional commands, e-mail: users-h...@wicket.apache.org
>> 

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Reply via email to