Hi all,

I try to build 7.3.0.0-SNAPSHOT from source, but there's at least the
following failing test. Skipping the tests builds OK and the results
seem to work, but that shouldn't be necessary, right?

[...]
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.398 sec - 
> in org.apache.wicket.spring.injection.annot.SpringBeanTest
> Running org.apache.wicket.spring.injection.annot.SpringBeanWithGenericsTest
> Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.557 sec <<< 
> FAILURE! - in 
> org.apache.wicket.spring.injection.annot.SpringBeanWithGenericsTestlistField(org.apache.wicket.spring.injection.annot.SpringBeanWithGenericsTest)
> Time elapsed: 0.072 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<3> but was:<1>
>         at org.junit.Assert.fail(Assert.java:88)
>         at org.junit.Assert.failNotEquals(Assert.java:834)
>         at org.junit.Assert.assertEquals(Assert.java:645)
>         at org.junit.Assert.assertEquals(Assert.java:631)
>         at 
> org.apache.wicket.spring.injection.annot.SpringBeanWithGenericsTest.listField(SpringBeanWithGenericsTest.java:143)
[...]

The mentioned line is the last one of the following quote:

>         @Test
>         public void listField() throws Exception
>         {
>                 AnnotatedListField page =
>                         tester.startPage(new AnnotatedListField());
>
>                 assertNotNull(page.getStringsList());
>                 assertEquals(3, page.getStringsList().size());

I've found the following commit, which introduced "getStringsList":

https://github.com/apache/wicket/commit/f0340a3ef62a18df14badb26acee01bf102b9a2c

The interesting part for me about that commit is that
"ConfigContextWithGenerics.getStrings" in the same file was NOT
changed as well. So I renamed to .stringsList and that did have an
effect, now another test is failing instead:

> Failed tests:
>   
> SpringBeanWithGenericsTest.listField:147->Assert.assertThat:923->Assert.assert
> That:956
> Expected: is <3>
>      but: was <1>

The only 1 element list in the class is "myList", so I guess that
"arrayListStrings" can't be found properly as well, only this time not
because of a wrong name, but maybe signature problems.

In the end, this test seems broken to me... Any further ideas, should
I file a bug? Thanks!

Mit freundlichen Grüßen,

Thorsten Schöning

-- 
Thorsten Schöning       E-Mail: [email protected]
AM-SoFT IT-Systeme      http://www.AM-SoFT.de/

Telefon...........05151-  9468- 55
Fax...............05151-  9468- 88
Mobil..............0178-8 9468- 04

AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to