Also the warning is logged for `null` objects, which probably shouldn't
happen.

public ChainingModel(final Object modelObject)
> {
>     if (modelObject instanceof Session)
>     {
>         LOG.warn("It is not a good idea to reference the .........");
>     } else if (modelObject instanceof Serializable == false)
>     {
>         LOG.warn("It is not a good idea to reference a non-serializable
> instance ....");
>     }
>     target = modelObject;
> }


It should read something like:

if (modelObject != null && modelObject instanceof Serializable == false)


Best,

Thomas


On Thu, Jun 7, 2018 at 4:25 PM, Thomas Heigl <tho...@umschalt.com> wrote:

> Hi all,
>
> After porting our app to Wicket 8, I'm getting these warnings on my test
> environment:
>
> WAR o.a.w.model.ChainingModel It is not a good idea to reference a
>> non-serializable instance in models directly as it may lead to
>> serialization problems
>
>
> The warning is OK, but it gives me absolutely no hint where to look for
> the issue. Could someone please add the (simple) class name of the model
> object to the warning message?
>
> Currently, the only way for me to find these issues is with a breakpoint
> in `ChainingModel` and clicking through my application until I hit the
> warning.
>
> Best,
>
> Thomas
>

Reply via email to