On 13/09/2021 5:19 pm, Martin Grigorov wrote:
On Mon, Sep 13, 2021 at 9:44 AM Martin Grigorov <mgrigo...@apache.org>
wrote:


On Mon, Sep 13, 2021 at 9:27 AM Chris Colman
<chr...@stepaheadsoftware.com.invalid> wrote:

You shouldn't use <wicket:enclosure> if you use EnclosureContainer.
Use a <div> instead.
It's weird how it's worked perfectly for many years for us in Wicket 6.x.

Maybe an extra note could be added to the 6.x -> 7.x migration guide in
case others experience this in their migration efforts.

We didn't do any changes in this area. Or at least I don't remember such.

What we could do is to improve EnclosureContainer to complain when used
with <wicket:enclosure>.

This won't work without adding more logic to Enclosure (the .java component
behind <wicket:enclosure>).
While trying to get the markup for EnclosureContainer Wicket triggers the
auto-component logic for <wicket:enclosure> and it fails with the error you
reported, so there is no way to get the ComponentTag at all.
I am against adding more logic to Enclosure.java because it has too many
problems already.

What I could do is to improve EnclosureContainer's javadoc to mention this.
Improve javadoc should to the trick: At least if people are made aware that they need to avoid using the <wicket:enclosure> tag altogether they should be fine.


Regards,
Chris

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org

Reply via email to