Alright. Thank you! On Tue, Jan 25, 2022 at 3:08 PM Martin Grigorov <mgrigo...@apache.org> wrote:
> Hi, > > On Tue, Jan 25, 2022 at 5:00 AM Michelle Ee Siew Phing < > michelle...@mcruncher.com> wrote: > > > Hi, > > Saw the update on this and thanks for fixing it. > > May I know when will 9.8.0 be available? Or will the fix be backported to > > > > Soon, but we don't have a specific date yet. > > > > an older version? > > > > No. We do not support older versions like 9.7.1 or 9.4.1. > We support latest versions of 8.x and 9.x, but this fix is needed only for > 9.x (and 10.x, but it is not released yet). > You could test the fix by: > 1) using 9.8.0-SNAPSHOT - add > > https://github.com/apache/wicket/blob/4ad5354a2a1baca55504c7ae4c3f794ddf609620/archetypes/quickstart/src/main/resources/archetype-resources/pom.xml#L179-L190 > to your application > 2) build Wicket 9.x locally > > > > Thanks again. > > > > On Fri, Jan 21, 2022 at 2:36 PM Michelle Ee Siew Phing < > > michelle...@mcruncher.com> wrote: > > > > > I have created an issue for this. > > > https://issues.apache.org/jira/browse/WICKET-6947 > > > > > > On Fri, Jan 21, 2022 at 11:45 AM Michelle Ee Siew Phing < > > > michelle...@mcruncher.com> wrote: > > > > > >> Hi, > > >> Yep, tried the SpinnerButton and it works. > > >> /Michelle > > >> > > >> On Fri, Jan 21, 2022 at 11:00 AM Maxim Solodovnik < > solomax...@gmail.com > > > > > >> wrote: > > >> > > >>> Have you tried the SpinnerButton from wicket-bootstrap? > > >>> > > >>> Does it work for you? > > >>> > > >>> from mobile (sorry for typos ;) > > >>> > > >>> > > >>> On Fri, Jan 21, 2022, 08:49 Michelle Ee Siew Phing < > > >>> michelle...@mcruncher.com> wrote: > > >>> > > >>> > Sorry... missed out the wicket.bootstrap.version > > >>> > > > >>> > <wicket.bootstrap.version>5.0.5</wicket.bootstrap.version> > > >>> > > > >>> > On Fri, Jan 21, 2022 at 9:35 AM Michelle Ee Siew Phing < > > >>> > michelle...@mcruncher.com> wrote: > > >>> > > > >>> >> Hi, > > >>> >> > > >>> >> Checking the examples again... the "hidden" is not removed after > > >>> clicking > > >>> >> on the button, but the style="display:inline" is appended. > > >>> >> [image: Screenshot from 2022-01-21 09-04-51.png] > > >>> >> > > >>> >> I think this would pose an issue with any .css that has the > > following > > >>> >> [hidden] { > > >>> >> > > >>> >> 1. display: none !important; > > >>> >> > > >>> >> } > > >>> >> Attached herewith the demo using the wicket quickstart > > >>> >> wicket-test-1.0-SNAPSHOT.war > > >>> >> < > > >>> > > > https://drive.google.com/file/d/1KM6Trg4NbcLHnH3pK8nx8S1PU4-L41Bd/view?usp=drive_web > > >>> > > > >>> >> > > >>> >> In the quick start codes, I've added > > >>> >> 1. the required dependencies [pom.xml] > > >>> >> <dependency> > > >>> >> <groupId>de.agilecoders.wicket</groupId> > > >>> >> <artifactId>wicket-bootstrap-core</artifactId> > > >>> >> <version>${wicket.bootstrap.version}</version> > > >>> >> </dependency> > > >>> >> > > >>> >> <dependency> > > >>> >> <groupId>de.agilecoders.wicket</groupId> > > >>> >> <artifactId>wicket-bootstrap-extensions</artifactId> > > >>> >> <version>${wicket.bootstrap.version}</version> > > >>> >> </dependency> > > >>> >> > > >>> >> 2. added BootstrapSettings [WicketApplication.java] > > >>> >> BootstrapSettings settings = new BootstrapSettings(); > > >>> >> Bootstrap.install(this, settings); > > >>> >> > > >>> >> 3. added necessary html elements > > >>> >> [HomePage.html] > > >>> >> <form wicket:id="form"> > > >>> >> <h1>Test Indicating Ajax Button</h1> > > >>> >> <input type="submit" wicket:id="testButton"/> > > >>> >> </form> > > >>> >> > > >>> >> [HomePage.java] > > >>> >> private Form addForm() > > >>> >> { > > >>> >> Form testForm = new Form("form"); > > >>> >> testForm.add(addTestButton(testForm)); > > >>> >> return testForm; > > >>> >> } > > >>> >> > > >>> >> private AjaxButton addTestButton(Form form) > > >>> >> { > > >>> >> return new IndicatingAjaxButton("testButton", > > Model.of("Sleep > > >>> for > > >>> >> a while"), form) > > >>> >> { > > >>> >> @Override > > >>> >> protected void onSubmit(AjaxRequestTarget target) > > >>> >> { > > >>> >> try { > > >>> >> Thread.sleep(3000); > > >>> >> } catch (InterruptedException e) { > > >>> >> e.printStackTrace(); > > >>> >> } > > >>> >> } > > >>> >> }; > > >>> >> } > > >>> >> > > >>> >> Could we get this fixed? > > >>> >> > > >>> >> /Michelle > > >>> >> > > >>> >> On Mon, Jan 17, 2022 at 3:07 PM Martin Grigorov < > > mgrigo...@apache.org > > >>> > > > >>> >> wrote: > > >>> >> > > >>> >>> Hi, > > >>> >>> > > >>> >>> Please check https://examples9x.wicket.apache.org/ajax/links. > > >>> >>> The third link demostrates usage of IndicatingAjaxLink. > > >>> >>> When clicked it adds style="display:inline" and removes "hidden". > > >>> >>> Its source code could be found at > > >>> >>> > > >>> >>> > > >>> > > > https://github.com/apache/wicket/blob/63c5fe205de1bea293e3b36ca8e0426b343ccafa/wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/LinksPage.java > > >>> >>> Please compare it with your app! > > >>> >>> If you are not able to find the problem then please create a mini > > >>> demo > > >>> >>> application and share it with us! > > >>> >>> > > >>> >>> On Mon, Jan 17, 2022 at 6:08 AM Michelle Ee Siew Phing < > > >>> >>> michelle...@mcruncher.com> wrote: > > >>> >>> > > >>> >>> > Hi, > > >>> >>> > > > >>> >>> > I am having issues with the loading icon on the > > >>> IndicatingAjaxButton > > >>> >>> and > > >>> >>> > IndicatingAjaxLink. Previously I'm on Wicket 9.0.0-M4 and it > was > > >>> >>> working > > >>> >>> > fine. But after upgrading to Wicket 9.0.0-M5 (and later > > versions), > > >>> I'm > > >>> >>> not > > >>> >>> > able to see the loading icon any longer. > > >>> >>> > > > >>> >>> > I checked further in the code that the AjaxIndicatorAppender > now > > >>> has > > >>> >>> the > > >>> >>> > hidden attribute instead of the style=display:none. However, > > when I > > >>> >>> click > > >>> >>> > the IndicatingAjaxButton, it will still append the > > >>> >>> style=display:inline as > > >>> >>> > before (but due to the hidden attribute, the icon will not > show). > > >>> >>> > > > >>> >>> > Is there anything else during the upgrade that I needed for the > > >>> >>> > IndicatingAjaxButton (and link) to work? > > >>> >>> > Please advise. > > >>> >>> > > > >>> >>> > Thank you. Regards. > > >>> >>> > Michelle > > >>> >>> > > > >>> >>> > > >>> >> > > >>> > > >> > > >
