Hi Vincent, my fix was only for Oracle DB, so this is not suitable to go for public. To be able to fix that in general, I would need to convert the code to use HQL, at least.
Anyway, how would I be able to create a new version of the macro and update it in extensions repository? Mirec > On 29.02.2016, at 14:30, vinc...@massol.net wrote: > > Hi Miroslav, > > On 29 Feb 2016 at 12:43:20, Miroslav Galajda > (miroslav.gala...@gmail.com(mailto:miroslav.gala...@gmail.com)) wrote: > >> Hi, I've tried it, because I was interested in. >> >> The macro is not very well implemented. >> Firstly: It uses direct SQL and is not working when running on Oracle DB, >> due to datetime format incompatibility. I've fixed it locally to work >> agains Oracle. >> Secondly: It is placed inside toplevel Macro space. Fortuntelly moving it >> and renaming it to something more suitable worked out of the box.. >> >> But, I'm happy that it works even with some fixes. > > Great that you fixed it. Do you think you could contribute your changes back? > > You could create a version 1.1 of the macro and put it on > http://extensions.xwiki.org/xwiki/bin/view/Extension/List+Connected+Users+Macro > ? > > That would help all future users. > > Thanks > -Vincent > > PS: BTW I agree that we need a better way. IMO we need an Event to be sent on > login/logout and an extension could then be created to maintain a list of > users who are connected. Note that an extension could already listen to the > “loginsubmit” and “logout” actions in addition to implementing a > HttpSessionBindingListener or HttpSessionListener#sessionDestroyed() (see > http://stackoverflow.com/a/3271748/153102). > > >> It would be nice if that macro would be reworked to use ORM instead of >> direct SQL access. Then the DB-specific problems should by gone. >> >> Mirec >> >> On 29 February 2016 at 10:11, Bruno wrote: >> >>> >>> Hello Vincent, >>> >>> I do not want to install the extension 'Connected Users List Macro' >>> because it requires to activate the statistics (which I do not want either). >>> My wish to list connected users is not essential. >>> >>> Thanks, >>> Signature mails >>> _________________________________________________ >>> >>> Bruno Joffredo >>> >>> Ecole Centrale de Nantes >>> >>> Centre de Ressources Informatiques - Bur. D019 >>> >>> 1 rue de la Noë >>> >>> BP 92101 >>> >>> F-44321 Nantes cedex 3 >>> >>> Tél. 02.40.37.68.06 >>> Mail : bruno.joffr...@ec-nantes.fr >>> _________________________________________________ >>> >>> >>> Le 23/02/2016 18:38, vinc...@massol.net a écrit : >>> >>>> On 23 Feb 2016 at 18:37:37, vinc...@massol.net (vinc...@massol.net >>>> (mailto:vinc...@massol.net)) wrote: >>>> >>>> Does it work? :) (why don’t you try it and let us know :)) >>>>> >>>> I don’t know of any other BTW. >>>> >>>> Thanks >>>> -Vincent >>>> >>>> Thanks >>>>> -Vincent >>>>> On 23 Feb 2016 at 15:23:06, Bruno (bruno.joffr...@ec-nantes.fr >>>>> (mailto:bruno.joffr...@ec-nantes.fr)) wrote: >>>>> >>>>> >>>>>> Hello, >>>>>> I try to list the connected users. >>>>>> I fall on "Connected Users List Macro" but it dates from 2014. >>>>>> Should I use this extension or is there another way to list open >>>>>> connections ? >>>>>> Thank you, >>>>>> Bruno Joffredo > _______________________________________________ > users mailing list > users@xwiki.org > http://lists.xwiki.org/mailman/listinfo/users _______________________________________________ users mailing list users@xwiki.org http://lists.xwiki.org/mailman/listinfo/users
